From owner-cvs-src@FreeBSD.ORG  Wed Feb 28 10:14:03 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 597B916A400;
	Wed, 28 Feb 2007 10:14:03 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 1863F13C4A6;
	Wed, 28 Feb 2007 10:14:03 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id 767AA170DC;
	Wed, 28 Feb 2007 10:14:01 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.8/8.13.8) with ESMTP id l1SAE0AX043469;
	Wed, 28 Feb 2007 10:14:00 GMT (envelope-from phk@critter.freebsd.dk)
To: "M. Warner Losh" <imp@bsdimp.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 28 Feb 2007 03:10:00 MST."
	<20070228.031000.1649769988.imp@bsdimp.com> 
Date: Wed, 28 Feb 2007 10:13:59 +0000
Message-ID: <43468.1172657639@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/usb umass.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Feb 2007 10:14:03 -0000

In message <20070228.031000.1649769988.imp@bsdimp.com>, "M. Warner Losh" writes
:

>: >  Create a new quirk READ_CAPACITY_OFFBY1 
>: 
>: A better idea would be to have scsi_da.c try to read the 
>: last sector and chop it if it fails.
>
>Why is that a better idea?

Because it will work automatically and not rely on us preventively
adding the bogus devices to the kernel.

Trivially testable quicks shouldn't have to be compiled into
static lists.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.