From owner-freebsd-usb@FreeBSD.ORG Sun Feb 1 18:30:17 2009 Return-Path: Delivered-To: freebsd-usb@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EEC42106564A; Sun, 1 Feb 2009 18:30:17 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 96B7B8FC0C; Sun, 1 Feb 2009 18:30:17 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n11IRRAS093378; Sun, 1 Feb 2009 11:27:27 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 01 Feb 2009 11:27:56 -0700 (MST) Message-Id: <20090201.112756.1320088159.imp@bsdimp.com> To: hselasky@c2i.net From: "M. Warner Losh" In-Reply-To: <200902011922.16810.hselasky@c2i.net> References: <200902011220.18745.hselasky@c2i.net> <20090201175021.GA32503@citylink.fud.org.nz> <200902011922.16810.hselasky@c2i.net> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-usb@FreeBSD.org, thompsa@FreeBSD.org Subject: Re: USB2 patches X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2009 18:30:18 -0000 In message: <200902011922.16810.hselasky@c2i.net> Hans Petter Selasky writes: : In your patch you remove all error checking! If the taskqueue system does not : have an API function that can tell if the taskqueue is being drained from : inside the taskqueue callback, the taskqueue system has to be modified! It : cannot replace the existing system like it is now! Why does the taskqueue system need to provide that? Why can't the driver set a dying flag in the softc to communicate this fact to the taskqueue tasks? Warner