From owner-freebsd-net@FreeBSD.ORG Fri Oct 17 02:59:36 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D75B106568E for ; Fri, 17 Oct 2008 02:59:36 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.171]) by mx1.freebsd.org (Postfix) with ESMTP id 7E5958FC20 for ; Fri, 17 Oct 2008 02:59:35 +0000 (UTC) (envelope-from max@love2party.net) Received: from vampire.homelinux.org (dslb-088-064-184-198.pools.arcor-ip.net [88.64.184.198]) by mrelayeu.kundenserver.de (node=mrelayeu0) with ESMTP (Nemesis) id 0MKwh2-1KqfYs074b-0006X0; Fri, 17 Oct 2008 04:59:34 +0200 Received: (qmail 41102 invoked from network); 17 Oct 2008 02:59:33 -0000 Received: from fbsd8.laiers.local (192.168.4.151) by ns1.laiers.local with SMTP; 17 Oct 2008 02:59:33 -0000 From: Max Laier Organization: FreeBSD To: freebsd-net@freebsd.org Date: Fri, 17 Oct 2008 04:59:32 +0200 User-Agent: KMail/1.10.1 (FreeBSD/8.0-CURRENT; KDE/4.1.1; i386; ; ) References: <20081016130318.J2978@maildrop.int.zabbadoz.net> In-Reply-To: <20081016130318.J2978@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810170459.32822.max@love2party.net> X-Provags-ID: V01U2FsdGVkX197EihulsRFJD3CO9HIZ98hZXm9K1Aw/+tgcmj UdMVmf734hwlQGLEAMEptcek4IVHHV9ISl9n2Xx2CR2h2n8m/D imbRPPuzyPs0ELJ8Ydh6w== Cc: "Bjoern A. Zeeb" Subject: Re: [patch] src port randomization for inet6 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Oct 2008 02:59:36 -0000 On Thursday 16 October 2008 15:05:16 Bjoern A. Zeeb wrote: > so since the very early day of src port randomization ipv6 was missing > that part while inet had it. Find a patch below. > Please test, review and report back... > > http://people.freebsd.org/~bz/20081004-07-ipv6-randomport.diff looks good from a casual review. Which is to say that it is in line with the in_pcb.c version. However, I find the comment: /* * Simple check to ensure all ports are not used up causing * a deadlock here. */ a bit dangling and not really in line with the actual code. The same is true for the v4 version. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News