From owner-freebsd-hackers Fri Jul 17 01:06:33 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA02939 for freebsd-hackers-outgoing; Fri, 17 Jul 1998 01:06:33 -0700 (PDT) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from oslo.geco-prakla.slb.com (geos01.oslo.geco-prakla.slb.com [134.32.44.131]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA02934 for ; Fri, 17 Jul 1998 01:06:29 -0700 (PDT) (envelope-from smoergrd@oslo.sl.slb.com) Received: from sunw110.oslo.Geco-Prakla.slb.com (sunw110 [192.23.231.54]) by oslo.geco-prakla.slb.com (8.8.8/8.6.9) with SMTP id KAA04592 ; Fri, 17 Jul 1998 10:01:10 +0200 (MET DST) Received: by sunw110.oslo.Geco-Prakla.slb.com (SMI-8.6/SMI-SVR4) id KAA19766; Fri, 17 Jul 1998 10:01:09 +0200 To: Mike Smith Cc: HAMADA Naoki , sbabkin@dcn.att.com, hackers@FreeBSD.ORG Subject: Re: NIC drivers References: <199807162021.NAA03930@antipodes.cdrom.com> Organization: Schlumberger Geco-Prakla X-Disclaimer: I speak only for myself. From: smoergrd@oslo.geco-prakla.slb.com (Dag-Erling Coidan Smørgrav) Date: 17 Jul 1998 10:01:09 +0200 In-Reply-To: Mike Smith's message of Thu, 16 Jul 1998 13:21:14 -0700 Message-ID: Lines: 31 X-Mailer: Gnus v5.3/Emacs 19.34 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Mike Smith writes: > If anyone has the chance to test this under -stable in the next few > days, please do so, as it'd be nice to have it in 2.2.7. Well, I don't have a -stable box right now, but from preliminary testing on my -current boxes, I'd recommend against it. I haven't had much time to track down the problem, but it would seem that a certain percentage of incoming packets go down a black hole. > > I carefully looked through the source code to find a bug which results > > mbuf leaks. Could you try this patch? > > > > -nao > > > > --- sys/i386/isa/if_ep.c- Wed Jul 15 15:40:09 1998 > > +++ sys/i386/isa/if_ep.c Wed Jul 15 15:41:04 1998 > > @@ -1128,8 +1128,7 @@ > > /* we see if by now, the packet has completly arrived */ > > goto read_again; > > } > > - outw(BASE + EP_COMMAND, SET_RX_EARLY_THRESH | RX_NEXT_EARLY_THRESH); > > - return; > > + goto out; > > } > > outw(BASE + EP_COMMAND, RX_DISCARD_TOP_PACK); > > ++ifp->if_ipackets; > > DES -- Dag-Erling Smørgrav - smoergrd@oslo.geco-prakla.slb.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message