Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 06 Dec 2012 21:25:28 +0100
From:      Marco Steinbach <coco@executive-computing.de>
To:        David Xu <davidxu@freebsd.org>
Cc:        freebsd-questions@freebsd.org
Subject:   Re: grep -Dskip doesn't skip FIFOs
Message-ID:  <50C0FF38.4020502@executive-computing.de>
In-Reply-To: <50C01518.5090705@freebsd.org>
References:  <alpine.BSF.2.00.1212052350170.36676@probsd.c0c0.intra> <50C010D0.3070205@freebsd.org> <50C01518.5090705@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
David Xu wrote on 06.12.2012 04:46:
> On 2012/12/06 11:28, David Xu wrote:
>> On 2012/12/06 07:07, Marco Steinbach wrote:
>>> Hi there,
>>>
>>> grep(1) does not seem to skip FIFOs when told to.
>>
>> <snip>
>>
>> I think you need a patch to fix it, the bug is in ggrep, it tries to
>> open a FIFO before checking if it is a FIFO, then blocked.
>>
>> http://people.freebsd.org/~davidxu/patch/grep.c.diff
>>
>> _______________________________________________
> 
>>
> 
> or the patch:
> http://people.freebsd.org/~davidxu/patch/grep.c.diff2
> 
> The patch opens file with O_NONBLOCK, then turns off O_NONBLOCK,
> and only checks if a file is a FIFO in reset() function.

This patch also seems to fix it.  I can't comment on the patches 
themselves, though.

Anyway, thank you again for taking care of this.

MfG CoCo



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50C0FF38.4020502>