From owner-freebsd-hackers@FreeBSD.ORG Sun Nov 3 00:20:18 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id AA433240 for ; Sun, 3 Nov 2013 00:20:18 +0000 (UTC) (envelope-from bounces+73574-4a99-freebsd-hackers=freebsd.org@sendgrid.me) Received: from o3.shared.sendgrid.net (o3.shared.sendgrid.net [208.117.48.85]) by mx1.freebsd.org (Postfix) with SMTP id 57D6220CA for ; Sun, 3 Nov 2013 00:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h=from:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=fxyJe9XytQfYSfTVo+B3r4By7k4=; b=XjO5zWNXLQ/0/xQapY Vy3LDOsVLFAy/PV1Pv9vLpspoMCvITzu5imgDvF0KI5Y6f0zrx4Pw2hA1yF3AqdF ur/g8Er8FCg6yHc3SpiarKuw+27l15f0jgp+KIb0hfsn+FZKRDHp/Iq7lpwC/NrJ Z6vG5fgbMWlhpdo7ZtQYF6Lq0= Received: by mf71.sendgrid.net with SMTP id mf71.1834.527596C06 Sun, 03 Nov 2013 00:20:16 +0000 (GMT) Received: from mail.tarsnap.com (unknown [10.60.208.13]) by mi24 (SG) with ESMTP id 1421b54dfe3.1346.1940a5 for ; Sat, 02 Nov 2013 19:20:16 -0500 (CST) Received: (qmail 82487 invoked from network); 3 Nov 2013 00:20:15 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by ec2-107-20-205-189.compute-1.amazonaws.com with ESMTP; 3 Nov 2013 00:20:15 -0000 Received: (qmail 33216 invoked from network); 3 Nov 2013 00:18:44 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 3 Nov 2013 00:18:44 -0000 Message-ID: <52759664.50800@freebsd.org> Date: Sat, 02 Nov 2013 17:18:44 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Benjamin Lee Subject: Re: Automated submission of kernel panic reports References: <526F8EB3.1040205@freebsd.org> <20131102171840.4505cb02@b1c1l1.com> In-Reply-To: <20131102171840.4505cb02@b1c1l1.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SG-EID: W2XBZA0V/n0voZZ6SjDkgjXvzGvkLIaljy40FLIRIHTVMXCc7ynl2WKQUz0qqp0cprgq76Bt3n6czqls2a7aJ0XzCToaXHADwRVGnH6Hg3XHfLZsBPGo1Dc1vXA7rHSMfLEnfUxkc3T6lAvUr5R/jqXrJNsWzjRJ2lnGywJS64I= Cc: freebsd-hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Nov 2013 00:20:18 -0000 On 11/02/13 17:18, Benjamin Lee wrote: > On Tue, 29 Oct 2013 03:32:19 -0700, Colin Percival wrote: >> Hi all, >> >> I've written some code for automatically submitting kernel panic reports, >> and I'd like some feedback before I place it into the ports tree. > > Just a style question, any reason not to place the file names into > variables? Something like: No reason to avoid it, I just don't see any need. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid