From owner-freebsd-current@FreeBSD.ORG Thu Jan 1 18:44:13 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CB265B32 for ; Thu, 1 Jan 2015 18:44:13 +0000 (UTC) Received: from mail-yh0-f52.google.com (mail-yh0-f52.google.com [209.85.213.52]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8BE40998 for ; Thu, 1 Jan 2015 18:44:13 +0000 (UTC) Received: by mail-yh0-f52.google.com with SMTP id z6so8618194yhz.11 for ; Thu, 01 Jan 2015 10:44:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=3y/kbWL28J4mvrevCARHxQrVfBMEiIKSvH6PErLEDDk=; b=j7vCYuyYAzE374iV3nfBsaSnnhCg3XLmK7MRux7871k4U3P25ui6CfxCXYa3r/8cDd jtPXOXhVpo094SG2hiA1o9Y7dmf6K/cd1FGtWyLb3aPlRVJ3MsQkHP8v5KCuSowS/uUJ RwR5iXJzADt7WUIJcnxOFFSua4ZD7mmQ8Wg4JZ3FnrxdjaYsA2uBcoOAHmgz7XdwRJU4 Wbo4x4LYfQ4hEtMPk1h6aHChLO/TLvMZd3M0ftJ9s4XT00wH8TKQqF6yy10L29h/ASxx SijVITJkJFrA22AfKExj9VMXFvmojnuVq8NXtYFOpxcYBytXBh4KnY3ZU3sUP1A2VLXG EIAQ== X-Gm-Message-State: ALoCoQk2aXTe6h6C1rdQiUsaek2Ki6FyGihyAvGu7hknQVlJF4eGXUwp4EREZ3DGAcIzRo8rtoiI MIME-Version: 1.0 X-Received: by 10.170.222.193 with SMTP id o184mr53375402ykf.68.1420137852253; Thu, 01 Jan 2015 10:44:12 -0800 (PST) Received: by 10.170.46.213 with HTTP; Thu, 1 Jan 2015 10:44:12 -0800 (PST) In-Reply-To: References: <528C023D-6207-4054-917B-05D4C4E605EC@FreeBSD.org> <20150101125043.6e6e3a52.ohartman@zedat.fu-berlin.de> Date: Thu, 1 Jan 2015 19:44:12 +0100 Message-ID: Subject: Re: HEADS UP: Upgraded clang, llvm and lldb to 3.5.0 From: Oliver Pinter To: Dimitry Andric Content-Type: text/plain; charset=UTF-8 Cc: HardenedBSD Developers , FreeBSD-Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jan 2015 18:44:14 -0000 No difference between FreeBSD's and our dis_tables.c file, and we added the following modification to "master" Makefile: op@robot hardenedBSD.git.opntr> git diff origin/master origin/hardened/current/master -- sys/cddl/dev/dtrace/x86/dis_tables.c op@robot hardenedBSD.git.opntr> git diff origin/master origin/hardened/current/master -- us usr.bin/ usr.sbin/ op@robot hardenedBSD.git.opntr> git diff origin/master origin/hardened/current/master -- share/mk mk/ mklocale/ op@robot hardenedBSD.git.opntr> git diff origin/master origin/hardened/current/master -- share/mk diff --git a/share/mk/Makefile b/share/mk/Makefile index cd69ca8..7e1b51f 100644 --- a/share/mk/Makefile +++ b/share/mk/Makefile @@ -13,6 +13,7 @@ FILES= \ bsd.doc.mk \ bsd.endian.mk \ bsd.files.mk \ + bsd.hardenedbsd.mk \ bsd.incs.mk \ bsd.info.mk \ bsd.init.mk \ diff --git a/share/mk/bsd.hardenedbsd.mk b/share/mk/bsd.hardenedbsd.mk new file mode 100644 index 0000000..9d5bcd3 --- /dev/null +++ b/share/mk/bsd.hardenedbsd.mk @@ -0,0 +1,2 @@ +CFLAGS+= -DHARDENEDBSD +CXXFLAGS+= -DHARDENEDBSD diff --git a/share/mk/sys.mk b/share/mk/sys.mk index f691820..1edb4d8 100644 --- a/share/mk/sys.mk +++ b/share/mk/sys.mk @@ -368,3 +368,5 @@ SHELL= ${__MAKE_SHELL} .include .endif # ! Posix + +.include and our origin/master is a vanilla copy of FreeBSD's master: op@robot hardenedBSD.git.opntr> git fetch freebsd remote: Counting objects: 2753, done. remote: Compressing objects: 100% (1653/1653), done. remote: Total 2753 (delta 1379), reused 1987 (delta 1088) Receiving objects: 100% (2753/2753), 6.19 MiB | 556.00 KiB/s, done. Resolving deltas: 100% (1379/1379), done. >From https://github.com/freebsd/freebsd 1daffcf..16bfeff master -> freebsd/master 4ce956b..2786226 projects/arm_intrng -> freebsd/projects/arm_intrng 8afde97..e891a45 projects/building-blocks -> freebsd/projects/building-blocks ae94017..79b9044 projects/clang350-import -> freebsd/projects/clang350-import * [new branch] projects/elftoolchain-update-r3130 -> freebsd/projects/elftoolchain-update-r3130 191c3a1..ef329bf projects/ifnet -> freebsd/projects/ifnet + f39bd7c...33c47ad projects/ino64 -> freebsd/projects/ino64 (forced update) * [new branch] projects/paravirt -> freebsd/projects/paravirt fdb4571..637702c projects/routing -> freebsd/projects/routing e3732e9..6970b8a projects/sendfile -> freebsd/projects/sendfile 73a106c..4bbc2e1 releng/10.0 -> freebsd/releng/10.0 29f4af5..8bdb2f8 releng/10.1 -> freebsd/releng/10.1 93a7c22..6c98ecd releng/8.4 -> freebsd/releng/8.4 18b185b..42bd402 releng/9.1 -> freebsd/releng/9.1 62fc296..81febb2 releng/9.2 -> freebsd/releng/9.2 587e3b5..825bd30 releng/9.3 -> freebsd/releng/9.3 f3fce3a..f0fc25a stable/10 -> freebsd/stable/10 038c20d..2a2bb65 stable/7 -> freebsd/stable/7 ab2b3fb..4ece3be stable/8 -> freebsd/stable/8 cd6870d..4c08e33 stable/9 -> freebsd/stable/9 dab26aa..b4e212b svn_head -> freebsd/svn_head 947b121..2d9be08 user/cperciva/freebsd-update-build -> freebsd/user/cperciva/freebsd-update-build e94160d..f74291e user/marcel/libvdsk -> freebsd/user/marcel/libvdsk aeef35a..7a5b8d5 user/pho/stress2 -> freebsd/user/pho/stress2 op@robot hardenedBSD.git.opntr> git diff freebsd/master origin/master op@robot hardenedBSD.git.opntr> And I started a new instance of build/ On Thu, Jan 1, 2015 at 7:20 PM, Oliver Pinter wrote: > No, we don't touch them. Only added -DHARDEBEDBSD into make > environment. I will schedule a new round of build to recheck them, > > On Thu, Jan 1, 2015 at 6:53 PM, Dimitry Andric wrote: >> On 01 Jan 2015, at 18:35, Oliver Pinter wrote: >>> We at HardenedBSD got this error, with out jenkins instance: >>> >>> --- dis_tables.o --- >>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25: >>> error: '&&' within '||' [-Werror,-Wlogical-op-parentheses] >>> if (cpu_mode == SIZE64 && dp->it_invalid64 || >>> ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ ~~ >>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3025:25: >>> note: place parentheses around the '&&' expression to silence this >>> warning >>> if (cpu_mode == SIZE64 && dp->it_invalid64 || >>> ^ >>> ( ) >>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25: >>> error: '&&' within '||' [-Werror,-Wlogical-op-parentheses] >>> cpu_mode != SIZE64 && dp->it_invalid32) >>> ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ >>> /jenkins/workspace/HardenedBSD_Master/sys/cddl/dev/dtrace/x86/dis_tables.c:3026:25: >>> note: place parentheses around the '&&' expression to silence this >>> warning >>> cpu_mode != SIZE64 && dp->it_invalid32) >>> ^ >>> ( ) >>> --- all_subdir_ed --- >> >> I can't reproduce this warning here, at least not with pristine head. >> >> Did you change any of the -Wno-xxx flags in your customized source tree? >> >> -Dimitry >>