From owner-svn-src-all@FreeBSD.ORG Sat Jul 12 15:31:33 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 70DF1819; Sat, 12 Jul 2014 15:31:33 +0000 (UTC) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 417192BC4; Sat, 12 Jul 2014 15:31:32 +0000 (UTC) Received: from c-50-155-136-3.hsd1.co.comcast.net ([50.155.136.3] helo=ilsoft.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1X5zGo-00082h-5R; Sat, 12 Jul 2014 15:31:26 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id s6CFVNcH003527; Sat, 12 Jul 2014 09:31:23 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.155.136.3 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/6XYry+Tr+fSYIPlo2N0Qn X-Authentication-Warning: paranoia.hippie.lan: Host revolution.hippie.lan [172.22.42.240] claimed to be [172.22.42.240] Subject: Re: svn commit: r268566 - head/usr.bin/users From: Ian Lepore To: Alexey Dokuchaev In-Reply-To: <20140712132705.GA45964@FreeBSD.org> References: <201407120747.s6C7lpYE020200@svn.freebsd.org> <20140712195452.N3279@besplex.bde.org> <53C12C1D.8080101@fastmail.net> <20140712132705.GA45964@FreeBSD.org> Content-Type: text/plain; charset="us-ascii" Date: Sat, 12 Jul 2014 09:31:23 -0600 Message-ID: <1405179083.91430.14.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, David Chisnall , Bruce Simpson , Bruce Evans , svn-src-head@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jul 2014 15:31:33 -0000 On Sat, 2014-07-12 at 13:27 +0000, Alexey Dokuchaev wrote: > On Sat, Jul 12, 2014 at 01:37:49PM +0100, Bruce Simpson wrote: > > On 12/07/2014 12:34, Bruce Evans wrote: > > >This joke is bad. The C++ version is worse in every way. > > > > I concur with everything you have said in your message. Moral of story: it > > is very, very easy to introduce bloat using C++, and using a higher level > > language does not automatically lead to better code quality. > > +1. Now the question is, how do we come out of this mess? Shall we redo > it in C again? Polish C++ version? Merge it with w(1) as suggested? > > ./danfe > It is in no way established that any kind of "mess" exists. All we have is some people who appear to hate C++ expressing their opinions about how they hate C++. All the whining about how many more bytes the compiled code is or many milliseconds something takes to compile don't add up to any actual problem. My opinion is that the original commit message was exactly correct: The code was rewritten to be cleaner and easier to understand and maintain. We need more of the same. -- Ian