Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Feb 2011 11:36:28 +0300
From:      Sergey Kandaurov <pluknet@freebsd.org>
To:        Giorgos Keramidas <keramida@freebsd.org>
Cc:        jhell <jhell@dataix.net>, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org, svn-src-stable@freebsd.org
Subject:   Re: svn commit: r218695 - stable/8/usr.bin/top
Message-ID:  <AANLkTim9F4bYV0CL6w6=XZ2Zb8td1uLYS3H6kmTzpCrC@mail.gmail.com>
In-Reply-To: <xeia4o84fp0b.fsf@kobe.laptop>
References:  <201102150633.p1F6XZrT020272@svn.freebsd.org> <alpine.BSF.2.00.1102152358240.1863@qvfongpu.qngnvk.ybpny> <xeia4o84fp0b.fsf@kobe.laptop>

next in thread | previous in thread | raw e-mail | index | archive | help
On 16 February 2011 09:54, Giorgos Keramidas <keramida@freebsd.org> wrote:
> On Wed, 16 Feb 2011 00:06:39 -0500, jhell <jhell@DataIX.net> wrote:
>> On Tue, 15 Feb 2011 01:33, keramida@ wrote:
>>> URL: http://svn.freebsd.org/changeset/base/218695
>>>
>>> =A0MFC 217746 from /head/usr.bin/top
>>>
>>> =A0Touch up the sample memory usage numbers a bit, to avoid wrapping
>>> =A0on terminal boundary. =A0While here add definition for 'G' and fix
>>> =A0the indentation of 'K' units.
> ..
>>> -.SH DESCRIPTION OF MEMORY
>>> -Mem: 9220K Active, 1032K Inact, 3284K Wired, 1M Cache, 2M Buf, 1320K F=
ree
>>> +.SH DESCRIPTION OF MEMORY
>>> +Mem: 9220K Active, 1M Inact, 3284K Wired, 1M Cache, 2M Buf, 1320K Free
>>> Swap: 91M Total, 79M Free, 13% Inuse, 80K In, 104K Out
>>
>> Maybe being a little picky here but consistency in this might persuade
>> further questions on why Active is using K but yet Inact "being
>> smaller" than that is using M.
>>
>> Might be best to just take some active values straight from a running
>> top(1) output rather than blindly adjusting them.
>
> On Wed, 16 Feb 2011 08:50:30 +0300, Sergey Kandaurov <pluknet@freebsd.org=
> wrote:
>> Well, that was already broken before the change.
>
> It's still not too late to do that. =A0I'll replace the Mem: line with on=
e
> from my current installation:
>
> Mem: 18M Active, 298M Inact, 119M Wired, 220K Cache, 110M Buf, 553M Free
>
> Does that look better?
>

>From my observations the line length (without trailing '/0') must be in [66=
,71]
range (both limits inclusive). Otherwise the line renders incorrectly for m=
e.
Yours is one character longer.

--=20
wbr,
pluknet



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTim9F4bYV0CL6w6=XZ2Zb8td1uLYS3H6kmTzpCrC>