From owner-freebsd-mips@FreeBSD.ORG Fri Apr 30 17:34:48 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 677AA106566C for ; Fri, 30 Apr 2010 17:34:48 +0000 (UTC) (envelope-from rrs@lakerest.net) Received: from lakerest.net (lakerest.net [70.155.160.98]) by mx1.freebsd.org (Postfix) with ESMTP id 94FFC8FC18 for ; Fri, 30 Apr 2010 17:34:47 +0000 (UTC) Received: from [10.1.1.53] ([10.1.1.53]) (authenticated bits=0) by lakerest.net (8.14.3/8.14.3) with ESMTP id o3UHD73p048055 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 30 Apr 2010 13:13:07 -0400 (EDT) (envelope-from rrs@lakerest.net) Message-Id: <3FC8C451-8FE2-4761-8A64-28761E07FEF2@lakerest.net> From: Randall Stewart To: "Jayachandran C." In-Reply-To: <4bdb0900.0d67f10a.0ae4.7784@mx.google.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Date: Fri, 30 Apr 2010 10:13:07 -0700 References: <4bdb0900.0d67f10a.0ae4.7784@mx.google.com> X-Mailer: Apple Mail (2.936) Cc: freebsd-mips@freebsd.org Subject: Re: Fix for pmap.c X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2010 17:34:48 -0000 JC: Thats definitely a bug and would only effect those that have >512Meg of memory. I have committed for you in rev 207441 R On Apr 30, 2010, at 9:48 AM, Jayachandran C. wrote: > There seems to be a obvious bug in the current pmap.c, can you please > review/apply the patch below. > > This seems to be the cause of the crashes I'm seeing in HEAD. I'm > still > testing with the patch, the buildworld I use will have to run a few > more > hours to be completely sure that this is the problem. > > JC. > > > Index: sys/mips/mips/pmap.c > =================================================================== > --- sys/mips/mips/pmap.c (revision 207433) > +++ sys/mips/mips/pmap.c (working copy) > @@ -236,7 +236,7 @@ > sched_pin(); \ > va1 = sysm->base; \ > va2 = sysm->base + PAGE_SIZE; \ > - npte = mips_paddr_to_tlbpfn(phys2) | \ > + npte = mips_paddr_to_tlbpfn(phys1) | \ > PTE_RW | PTE_V | PTE_G | PTE_W | PTE_CACHE; \ > pte = pmap_pte(kernel_pmap, va1); \ > *pte = npte; \ > ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)