From nobody Thu Aug 29 02:14:56 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvPxY1DGrz5Strw for ; Thu, 29 Aug 2024 02:14:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvPxX5SRYz4X2B for ; Thu, 29 Aug 2024 02:14:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724897696; a=rsa-sha256; cv=none; b=tKgZXd8BCLRh0gXiXLwCbtkLYXGlqQfibNFIU3GCOPyRLlqVm5bBXEds0teB7vXlAx/50i nedt7WF9GLw7xtxy9cLMPdtd1eVT39lm2tqP+nPfk1SjVQ/kbDoxgRf4+j3lecuuu4sH9T fZRMSk1tk7yHsddW9Qu2DMmAUPwmBupESjJ7eOWnWSUbSBw30mxR+BhjkiyVrts81/OGzo x/hhD9RfSqe8N69MloHPTJjczX1VyHH/OvWMaVl8qFCQ/J3PZhOMcbnxGjOvsAitxN11EZ T9kVJ1f5SPKGKXsn2LVPYVFur3xT98JOcI8D1AFJIQyPo+KOT9Di8bU1LpfxYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724897696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f+IziWjuTfvW+QtvPGhITbGEGU1b0x9B9x7K5N2PgAw=; b=gsOJp9FKikTmVhPLZ73sf8o+7bl3ae+iau9BsQa3t91tPSIkeDwg7eB5dIoqt3wibs4FwF qownA0/pBpEbDLDFWoymeon9soa3wf/XRvtu4Oliewh79n62E9vcK1YqHsHfJGfpI5VV3p LrX/UeJcZnTPb8DnPDqWa+6SL3VIvM8Rpb7FOygP2tu3ssq/oWG5DspDegf9fQQTgW2nX2 DJhDbBzflfnjAqbktG4cznCzR+D8DcYl6XuPhQc31Ju3R3heRGpOfRHv0JuOFOmhXP+W9Y vL+iAmFMRP50wnwOKcO6ZfLmcaD2lwINMEq5xxJrHDDs/ZQrHJrj+IYMn7x9dw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvPxX54wWzybJ for ; Thu, 29 Aug 2024 02:14:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47T2Euvn072050 for ; Thu, 29 Aug 2024 02:14:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47T2EuLJ072049 for ports-bugs@FreeBSD.org; Thu, 29 Aug 2024 02:14:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 281118] sysutils/munin-node: plugins/zfs_compress will throw an error if the label contains `.`, resulting in data loss. Date: Thu, 29 Aug 2024 02:14:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: takefu@airport.fm X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: flo@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281118 Bug ID: 281118 Summary: sysutils/munin-node: plugins/zfs_compress will throw an error if the label contains `.`, resulting in data loss. Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: flo@FreeBSD.org Reporter: takefu@airport.fm Flags: maintainer-feedback?(flo@FreeBSD.org) Assignee: flo@FreeBSD.org Created attachment 253155 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D253155&action= =3Dedit adhoc to plugins/zfs_compress The munin-master execution log shows the following error and missing data 2024/08/29 00:00:00 [ERROR] config error under [] for 'GROUP1;finger1.north1.airport.fm:zfs_compress.zroot__ROOT__14.1-RELEASE-p1= _2024-07-01_211548.value 1.00' : Parse error in /var/munin/datafile for zfs_compress.zroot__ROOT__14.1-RELEASE-p1_2024-07-01_211548.value: Unknown keyword at end of left hand side of line 7886 (zfs_compress.zroot__ROOT__14.1-RELEASE-p1_2024-07-01_211548.value ) at /usr/local/lib/perl5/site_perl/Munin/Master/Update.pm line 83. # zfs get -t filesystem -H compressratio ..snip.. ZFS/ROOT/14.1-RELEASE-p1_2024-07-04_232340 compressratio 1.00x - # telnet localhost 4949 fetch zfs_compress ..snip.. ZFS__ROOT__14.1-RELEASE-p1_2024-07-04_232340.label ZFS/ROOT/14.1-RELEASE-p1_2024-07-04_232340 ZFS__ROOT__14.1-RELEASE-p1_2024-07-04_232340.value 1.00 The `.` is used for internal separation, but if it is present in the label name, munin-update will behave unexpectedly. I tried to get around this by converting `.` to `_`. # telnet localhost 4949 fetch zfs_compress ..snip.. ZFS__ROOT__14_1-RELEASE-p1_2024-07-04_232340.label ZFS/ROOT/14.1-RELEASE-p1_2024-07-04_232340 ZFS__ROOT__14_1-RELEASE-p1_2024-07-04_232340.value 1.00 This is a minor change that occurs after the patch level is bumped in freebsd-update, so I don't think there's any need to bump PORTREVISION. --=20 You are receiving this mail because: You are the assignee for the bug.=