From owner-freebsd-scsi Wed Aug 28 11:45:19 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0846637B400 for ; Wed, 28 Aug 2002 11:45:17 -0700 (PDT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D6D943E42 for ; Wed, 28 Aug 2002 11:45:16 -0700 (PDT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.3/8.12.3) with ESMTP id g7SIjEwu007937; Wed, 28 Aug 2002 11:45:14 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.3/8.12.3/Submit) id g7SIjEki007936; Wed, 28 Aug 2002 11:45:14 -0700 Date: Wed, 28 Aug 2002 11:45:14 -0700 From: Brooks Davis To: Nate Lawson Cc: Brooks Davis , scsi@FreeBSD.ORG Subject: Re: [PATCH] make SCSI_DELAY tunable Message-ID: <20020828114514.A7073@Odin.AC.HMC.Edu> References: <20020828103933.A24804@Odin.AC.HMC.Edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="FL5UXtIhxfXey3p5" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from nate@root.org on Wed, Aug 28, 2002 at 11:22:49AM -0700 X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 28, 2002 at 11:22:49AM -0700, Nate Lawson wrote: > Why the move from scsi_all.h to scsi_all.c for the #defined stuff? It's > needed elsewhere. No it's not. After this patch scsi_all.c is the only consumer of SCSI_DELAY and the old consumers use scsi_delay instead. I moved the #define portion there rather then polluting all files that include scsi_all.h with opt_scsi.h and #defines for variables they shouldn't use. This way helps insure that new consumers of SCSI_DELAY don't appear by accident. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --FL5UXtIhxfXey3p5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9bRo2XY6L6fI4GtQRAuuOAJ9ggfvNZR+6h2JWFH/bBcFZfUKdfACgzSdy Ve6IQGRDt+EjtwctTjikW/8= =f1Jp -----END PGP SIGNATURE----- --FL5UXtIhxfXey3p5-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message