From owner-freebsd-net@FreeBSD.ORG Thu May 15 05:26:27 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D2EC5E1C; Thu, 15 May 2014 05:26:27 +0000 (UTC) Received: from mail-qg0-x230.google.com (mail-qg0-x230.google.com [IPv6:2607:f8b0:400d:c04::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E4EF226B; Thu, 15 May 2014 05:26:27 +0000 (UTC) Received: by mail-qg0-f48.google.com with SMTP id i50so931392qgf.35 for ; Wed, 14 May 2014 22:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=CpDsdyDMfcRI9cGao7L4svj6N3YB5E4hD50EtYZNPBE=; b=zH7gVi035I+gHEmEMJgaflF690C8o3trLsbqTY4yJENwWOL2UeR1Hzr2ti5pfh3cMs 6GO05pP+fEGqd3ONZTKbFmjO5WQfqIfT4k59yPvlmEDiM8zIDUmbN+9XP+MPUHx2CynQ KyIw305O1mSY7nvNo6MGOp0URzAKQyDDUrUxPsnZ5Uz4qAUtNjsLMXUnB3JM/gnxY9+p xoI3tgfySuU4fB4kuDRaaVYdsloRiTDo8cCFtYlxQXm1mXt8c7nCg01jBt+c8nrl+rTl jRRoO9IqQ9p/ONgNWqUzJyZgrOVIJULXuIYBZRLGnE3zUGrPLKvEGylHM942ujeyABeV p2nQ== MIME-Version: 1.0 X-Received: by 10.224.51.2 with SMTP id b2mr9844840qag.49.1400131586528; Wed, 14 May 2014 22:26:26 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.191.201 with HTTP; Wed, 14 May 2014 22:26:26 -0700 (PDT) In-Reply-To: References: Date: Wed, 14 May 2014 22:26:26 -0700 X-Google-Sender-Auth: g60kka5dSxI-4RNDAXWB8t4jZCs Message-ID: Subject: Re: [rfc] tcp timer update for RSS From: Adrian Chadd To: "freebsd-arch@freebsd.org" , FreeBSD Net Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 May 2014 05:26:27 -0000 .. and i've done a little more than no testing, so far so good. http://people.freebsd.org/~adrian/norse/20140514-tcp-rss-timers-2.diff This adds IP_FLOWID, IP_FLOWTYPE and IP_RSSCPUID to fetch the socket flowid, flowtype and cpuid from the inp. It's mostly for debugging for now. Thanks, -a On 14 May 2014 21:43, Adrian Chadd wrote: > Hi, > > here's a completely untested patch for discussion. I'm emailing it out > mostly as a "is this a good idea" patch rather than a "it should just > be committed" patch. > > The RSS stuff from Robert maps connections to pcbgroups based on the > RSS hash, but it doesn't map the TCP timers the same way. So by > default they're all on swi0 and the per CPU timers don't take the hash > type or correctly choose the CPU. > > This patch: > > http://people.freebsd.org/~adrian/norse/20140514-tcp-rss-timers-1.diff > > does a few things: > > * it stores the hashtype in the inp as well as the flowid; > * the rss code grows a new method that maps the flowid/hashtype to a cpuid > * .. and the existing mbuf to cpuid method now uses this; > * the tcp timer code now has an inline function that knows about RSS > and defaults to the existing way of doing things if RSS isn't enabled. > > There's still a bunch of work left before all the lock contention > compartmentalization and balancing of RSS is realised. I'm just > chewing off the little corner bits that are easy to get done now. > > So, any comments? I'll give it a proper whirl on some 10G hardware in > a few days but I thought I'd at least get the general idea out there > for comment. > > Thanks, > > > > > -a