From owner-freebsd-java@FreeBSD.ORG Tue Mar 20 00:00:52 2012 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D38401065676 for ; Tue, 20 Mar 2012 00:00:52 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 966568FC0C for ; Tue, 20 Mar 2012 00:00:52 +0000 (UTC) Received: by pbcwz17 with SMTP id wz17so1564883pbc.13 for ; Mon, 19 Mar 2012 17:00:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-operating-system :organization:x-living-the-dream:x-pgp-fingerprint:x-pgp-key :user-agent:x-gm-message-state; bh=x11mC7Ttp2/bpYAS4YD0J5wfstiMZ+Da9wriQyB75MU=; b=NVjSe71vE4J7jABOHnoJcjZlFU372mWyZRen9bUuHsLHB+x1gdMWECe/vhEtGiM454 EMrUjznHO/0xj+vYFxp7PBFubxydJ3afowbVGpGLkY5nQ3BaoOvlXE2qxvHPk2lMiYbh KLiS261rHOdFy44/h43aSNe5jvFBmeVKRj0a52G3FyBhGW4AiDhUsJ/keHosJASWijwf KRhToFnrSQKH6gLUUatvb3+/K9hec16PoEnzlHI7CfffjSNv4e3uvTGSYtMBptb0gbyg +6YjdiHoHia+37jIQ9E3WA95QEfThlf68aS29vgqq8iwiShE/9TbsIfHJZxLjShzD1Cm 8EvA== Received: by 10.68.203.4 with SMTP id km4mr3071722pbc.53.1332201652213; Mon, 19 Mar 2012 17:00:52 -0700 (PDT) Received: from dormouse.experts-exchange.com ([72.29.164.238]) by mx.google.com with ESMTPS id u10sm12354250pbf.37.2012.03.19.17.00.50 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 19 Mar 2012 17:00:51 -0700 (PDT) Sender: Jason Helfman Date: Mon, 19 Mar 2012 16:59:59 -0700 From: Jason Helfman To: Jung-uk Kim Message-ID: <20120319235959.GL46825@dormouse.experts-exchange.com> References: <20120318180225.GA51618@dormouse.experts-exchange.com> <201203191900.42677.jkim@FreeBSD.org> <20120319230818.GJ46825@dormouse.experts-exchange.com> <201203191945.50219.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <201203191945.50219.jkim@FreeBSD.org> X-Operating-System: FreeBSD 8.2-RELEASE amd64 Organization: The FreeBSD Project, http://www.freebsd.org X-Living-The-Dream: I love the SLO Life! X-PGP-FingerPrint: 8E0D C457 9A0F C91C 23F3 0454 2059 9A63 4150 D3DC X-PGP-Key: http://people.freebsd.org/~jgh/jgh.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQn7H5ZImH325rX8YuvKscyB9Hs3WWTBJJR2h9TxXhd8Oi4Z1NvtPlIXHTAyUigO6akDAQSB Cc: freebsd-eclipse@FreeBSD.org, freebsd-java@freebsd.org Subject: Re: [RFC] New Port: Eclipse Java Compiler, java/eclipse-ecj X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2012 00:00:53 -0000 On Mon, Mar 19, 2012 at 07:45:45PM -0400, Jung-uk Kim thus spake: >On Monday 19 March 2012 07:08 pm, Jason Helfman wrote: >> On Mon, Mar 19, 2012 at 07:00:39PM -0400, Jung-uk Kim thus spake: >> >Hmm... It doesn't seem right. >> > >> >% cat /usr/local/bin/ecj.sh >> >#!/bin/sh >> > >> >/usr/local/openjdk6/bin/javac -classpath >> > /usr/local/share/java/classes/ecj.jar $1 % /usr/local/bin/ecj.sh >> > -version >> >javac 1.6.0_30 >> >% /usr/local/openjdk6/bin/javac -version >> >javac 1.6.0_30 >> > >> >Please note it isn't coming from ecj.jar. >> >> That is grabbing the version of javac based on the shell script. > >Yes, that's exactly my point. :-) > >> I'm not certain if you can get a vesion of the jar with an >> argument, or if that argument is even valid. > >Of course, it is valid: > >% fetch >http://download.eclipse.org/eclipse/downloads/drops/R-3.7.2-201202080800/ecj-3.7.2.jar >ecj-3.7.2.jar 100% of 1708 kB 1851 >kBps >% /usr/local/openjdk6/bin/java -jar ecj-3.7.2.jar -version >Eclipse Compiler for Java(TM) 0.B83_R37x, 3.7.2, Copyright IBM Corp >2000, 2011. All rights reserved. I am unable to validate this with the jar that is built. Are you able to get it to work? > >> >Also, `$1' should be `$*'. >> >> I can change this. > >Thanks. > >While you are at it, please add these: > >USE_ZIP= yes Why? It isn't a zip file, and why is this dependency required? >NO_WRKSUBDIR= yes Can't see why this would be an issue to put in. > >and remove these: > >BUILD_WRKSRC= ${WRKDIR} Why? Otherwise, I need to put: WRKSRC= ${WRKDIR} Seems silly when bpm supports a different BUILD worksource. >... >EXTRACT_CMD= ${TAR} >EXTRACT_BEFORE_ARGS= xf >EXTRACT_AFTER_ARGS= -C ${WRKDIR} Why on these, as well? I'm not using zip, and zip is in different locations based on different releases of the Operating System. > >Jung-uk Kim > -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh