Date: Mon, 19 Mar 2012 16:59:59 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: freebsd-eclipse@FreeBSD.org, freebsd-java@freebsd.org Subject: Re: [RFC] New Port: Eclipse Java Compiler, java/eclipse-ecj Message-ID: <20120319235959.GL46825@dormouse.experts-exchange.com> In-Reply-To: <201203191945.50219.jkim@FreeBSD.org> References: <20120318180225.GA51618@dormouse.experts-exchange.com> <201203191900.42677.jkim@FreeBSD.org> <20120319230818.GJ46825@dormouse.experts-exchange.com> <201203191945.50219.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 19, 2012 at 07:45:45PM -0400, Jung-uk Kim thus spake: >On Monday 19 March 2012 07:08 pm, Jason Helfman wrote: >> On Mon, Mar 19, 2012 at 07:00:39PM -0400, Jung-uk Kim thus spake: >> >Hmm... It doesn't seem right. >> > >> >% cat /usr/local/bin/ecj.sh >> >#!/bin/sh >> > >> >/usr/local/openjdk6/bin/javac -classpath >> > /usr/local/share/java/classes/ecj.jar $1 % /usr/local/bin/ecj.sh >> > -version >> >javac 1.6.0_30 >> >% /usr/local/openjdk6/bin/javac -version >> >javac 1.6.0_30 >> > >> >Please note it isn't coming from ecj.jar. >> >> That is grabbing the version of javac based on the shell script. > >Yes, that's exactly my point. :-) > >> I'm not certain if you can get a vesion of the jar with an >> argument, or if that argument is even valid. > >Of course, it is valid: > >% fetch >http://download.eclipse.org/eclipse/downloads/drops/R-3.7.2-201202080800/ecj-3.7.2.jar >ecj-3.7.2.jar 100% of 1708 kB 1851 >kBps >% /usr/local/openjdk6/bin/java -jar ecj-3.7.2.jar -version >Eclipse Compiler for Java(TM) 0.B83_R37x, 3.7.2, Copyright IBM Corp >2000, 2011. All rights reserved. I am unable to validate this with the jar that is built. Are you able to get it to work? > >> >Also, `$1' should be `$*'. >> >> I can change this. > >Thanks. > >While you are at it, please add these: > >USE_ZIP= yes Why? It isn't a zip file, and why is this dependency required? >NO_WRKSUBDIR= yes Can't see why this would be an issue to put in. > >and remove these: > >BUILD_WRKSRC= ${WRKDIR} Why? Otherwise, I need to put: WRKSRC= ${WRKDIR} Seems silly when bpm supports a different BUILD worksource. >... >EXTRACT_CMD= ${TAR} >EXTRACT_BEFORE_ARGS= xf >EXTRACT_AFTER_ARGS= -C ${WRKDIR} Why on these, as well? I'm not using zip, and zip is in different locations based on different releases of the Operating System. > >Jung-uk Kim > -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120319235959.GL46825>