From owner-freebsd-current@FreeBSD.ORG Tue May 17 22:31:18 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE68816A4CE for ; Tue, 17 May 2005 22:31:18 +0000 (GMT) Received: from mail.hamnpolare.net (manticore.shapeshifter.se [212.37.5.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id D52CA43DE4 for ; Tue, 17 May 2005 22:31:17 +0000 (GMT) (envelope-from fli+freebsd-current@shapeshifter.se) Received: from localhost (localhost [127.0.0.1]) by mail.hamnpolare.net (Postfix) with ESMTP id 3EF821A6F0; Wed, 18 May 2005 00:31:14 +0200 (CEST) Received: from mail.hamnpolare.net ([127.0.0.1])port 10024) with ESMTP id 04918-04; Wed, 18 May 2005 00:31:11 +0200 (CEST) Received: from biocandy.shapeshifter.se (h99n2fls32o270.telia.com [217.210.25.99]) by mail.hamnpolare.net (Postfix) with ESMTP id 6B6471A6D5; Wed, 18 May 2005 00:31:11 +0200 (CEST) Received: by biocandy.shapeshifter.se (Postfix, from userid 1001) id 1D5E54289; Wed, 18 May 2005 00:31:11 +0200 (CEST) Date: Wed, 18 May 2005 00:31:11 +0200 From: Fredrik Lindberg To: Poul-Henning Kamp Message-ID: <20050517223110.GA9359@shapeshifter.se> References: <20050517163627.GA20732@shapeshifter.se> <8437.1116351704@critter.freebsd.dk> <20050517201835.GA851@shapeshifter.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050517201835.GA851@shapeshifter.se> User-Agent: Mutt/1.4.2.1i X-Virus-Scanned: at example.com cc: freebsd-current@freebsd.org Subject: Re: Patch to make powerd(8) devd(8)-aware X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2005 22:31:18 -0000 On Tue, May 17, 2005 at 10:18:35PM +0200, Fredrik Lindberg (fli+freebsd-current@shapeshifter.se) wrote: > On Tue, May 17, 2005 at 07:41:44PM +0200, Poul-Henning Kamp (phk@phk.freebsd.dk) wrote: > > In message <20050517163627.GA20732@shapeshifter.se>, Fredrik Lindberg writes: > > >On Mon, May 16, 2005 at 10:58:20PM +0200, Poul-Henning Kamp (phk@phk.freebsd.dk) wrote: > > >> In message <20050516.145207.39180036.imp@bsdimp.com>, Warner Losh writes: > > >> > > >> >OK. I've just committed my take on the change. Please let me know if > > >> >this causes you problems. > > >> > > >> While you're on this: I see powerd dying with ENOMEM about once or twice > > >> per day... > > >> > > > > > >I'm unable to reproduce this. I've been running powerd (without the devd-patch) > > >all day now without any problems. As far as I can tell it does not appear to > > >grow in size either... > > > > I think it may be the sysctl failing with ENOMEM. In that case we should > > just abandon and try again next time. > > > > Ah, yes that's probably it. The code contains alot of err/errx calls around the > sysctls. Once the initialization has been completed successfully it shouldn't > choke on temporary failures. I'll try to clean this up. > > Fredrik Lindberg I've put together a new patch, all calls to err/errx has been changed to warn/warnx and put behind the verbose flag. I also polished the devd code and made it work properly if the pipe to devd dies. The patch is at http://shapeshifter.se/~fli/freebsd/powerd.patch It includes all devd code so the previous patch is not needed. Fredrik Lindberg