From owner-freebsd-current@freebsd.org Mon Nov 23 19:18:39 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 04E6846A32C for ; Mon, 23 Nov 2020 19:18:39 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CfxlL21Hzz4gYw; Mon, 23 Nov 2020 19:18:38 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-lf1-f53.google.com with SMTP id d17so25319080lfq.10; Mon, 23 Nov 2020 11:18:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=THrgWD3wMrti/wOZbqEg5aGdMDmILpUY5UzG/iLmxdk=; b=fyMKskyYTMKJE7zZqNR7/DcIehY/F9Mz9Gn1XwmIBNMkCXzYSXez3m0XaQvXX3Bu5K XvRCpG/KneGdfaRCYzNdoG8uQSGUCyFPmCMt7+rsdBO73R3/969H+yvyxSBid+iD87W0 2Upy9XvHQ2tnVKdAZ6ympFljudU86VkxHhrv5A6YvdmVHNOwO/JySRSpql3Zuti6TjM9 F3j58wRVbPcb5yxWaf7Ia3rzhARCzVGwwDEvFid/yAc7R5856kGasd3tUhbwEA52+h4j fgJun6ZbA3eyvgPXmwRXGJrlE4EHVrf47aqbkG2IiL8731PjoIJX1gGDt5B9jemZfPAg K43g== X-Gm-Message-State: AOAM532RgTRUI9nwebmfVsG4RMxf6j2ZfJxgY3gtfPFRtW3CZwc0TbvV PjzYsXw9r/Q2tdvBKiizv0QFQw2HySGDNg== X-Google-Smtp-Source: ABdhPJxY99jjj2agbl3Y8EbOCf7wesQwswq72i5WZIe4we7/yxUtw/xKEb/yvJRHCLo+Ja5qcPYDAQ== X-Received: by 2002:a05:6512:3e7:: with SMTP id n7mr227395lfq.585.1606159116138; Mon, 23 Nov 2020 11:18:36 -0800 (PST) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id d9sm61884ljc.63.2020.11.23.11.18.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Nov 2020 11:18:35 -0800 (PST) Subject: Re: buildworld: lib/libc: install: short write to libc.so.7.debug: [_libinstall] Error code 71 To: Kyle Evans , Dimitry Andric Cc: Graham Perrin , FreeBSD-CURRENT , Alex Richardson , Ryan Moeller , Matthew Macy References: <746a3af4-3daf-9029-bf48-23efa3f5da8e@gmail.com> <37d2a873-8cb9-b858-fa06-4bbfcf006835@gmail.com> <1e9e8649-0fe7-4b83-078d-f67908e2f430@gmail.com> <40C5DB30-4B7C-4A51-8069-B4E67298C558@FreeBSD.org> From: Andriy Gapon Message-ID: Date: Mon, 23 Nov 2020 21:18:33 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Firefox/60.0 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4CfxlL21Hzz4gYw X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.91 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.91)[-0.915]; RCPT_COUNT_SEVEN(0.00)[7]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[93.72.151.96:received]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.167.53:from]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; SPAMHAUS_ZRD(0.00)[209.85.167.53:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.53:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.53:from]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2020 19:18:39 -0000 On 22/11/2020 18:06, Kyle Evans wrote: > On Sun, Nov 22, 2020 at 6:00 AM Dimitry Andric wrote: >> I'd guess it's an unintended side-effect of >> https://svnweb.freebsd.org/base?view=revision&revision=366697 >> ("install(1): Avoid unncessary fstatfs() calls and use mmap() based on >> size"). >> > > Almost certainly -- before, we would never attempt to mmap() on ZFS. > > Tossing arichardson@ into CC as the committer > Tossing mmacy@ and freqlabs@ into CC as ZFS folks > > Looking through sys/contrib/openzfs, there's special handling for mmap > on linux because it bypasses the page cache and relies on caching in > ARC. AFAICT the FreeBSD side seems to handle write() to mmap'd > regions, but doesn't do anything with VOP_MMAPPED which might be > needed to sync the file when it's mmap'd for reading like this. My > understanding of how this is supposed to actually work on FreeBSD is > limited, though, so I defer... Last time I checked mmap worked correctly with ZFS, that was before the switch. Perhaps, there was an undetected issue -- this can be tested, e.g., by applying the install change to stable/12. Perhaps, the ZFS switch came with a regression. -- Andriy Gapon