Date: Mon, 23 Nov 2020 21:18:33 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Kyle Evans <kevans@freebsd.org>, Dimitry Andric <dim@freebsd.org> Cc: Graham Perrin <grahamperrin@gmail.com>, FreeBSD-CURRENT <freebsd-current@freebsd.org>, Alex Richardson <arichardson@freebsd.org>, Ryan Moeller <freqlabs@freebsd.org>, Matthew Macy <mmacy@freebsd.org> Subject: Re: buildworld: lib/libc: install: short write to libc.so.7.debug: [_libinstall] Error code 71 Message-ID: <b5e3f730-da87-97df-09aa-7fa72e153b3a@FreeBSD.org> In-Reply-To: <CACNAnaGh9QWCOdbojfVpibrbewNFKgjgvQ4YPdtv5zTehW%2BXbA@mail.gmail.com> References: <746a3af4-3daf-9029-bf48-23efa3f5da8e@gmail.com> <37d2a873-8cb9-b858-fa06-4bbfcf006835@gmail.com> <1e9e8649-0fe7-4b83-078d-f67908e2f430@gmail.com> <40C5DB30-4B7C-4A51-8069-B4E67298C558@FreeBSD.org> <CACNAnaGh9QWCOdbojfVpibrbewNFKgjgvQ4YPdtv5zTehW%2BXbA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22/11/2020 18:06, Kyle Evans wrote: > On Sun, Nov 22, 2020 at 6:00 AM Dimitry Andric <dim@freebsd.org> wrote: >> I'd guess it's an unintended side-effect of >> https://svnweb.freebsd.org/base?view=revision&revision=366697 >> ("install(1): Avoid unncessary fstatfs() calls and use mmap() based on >> size"). >> > > Almost certainly -- before, we would never attempt to mmap() on ZFS. > > Tossing arichardson@ into CC as the committer > Tossing mmacy@ and freqlabs@ into CC as ZFS folks > > Looking through sys/contrib/openzfs, there's special handling for mmap > on linux because it bypasses the page cache and relies on caching in > ARC. AFAICT the FreeBSD side seems to handle write() to mmap'd > regions, but doesn't do anything with VOP_MMAPPED which might be > needed to sync the file when it's mmap'd for reading like this. My > understanding of how this is supposed to actually work on FreeBSD is > limited, though, so I defer... Last time I checked mmap worked correctly with ZFS, that was before the switch. Perhaps, there was an undetected issue -- this can be tested, e.g., by applying the install change to stable/12. Perhaps, the ZFS switch came with a regression. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b5e3f730-da87-97df-09aa-7fa72e153b3a>