From owner-freebsd-current@FreeBSD.ORG Wed Aug 23 17:38:31 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 927B916A4DF for ; Wed, 23 Aug 2006 17:38:31 +0000 (UTC) (envelope-from amogilny@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.188]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0A6443D6E for ; Wed, 23 Aug 2006 17:38:26 +0000 (GMT) (envelope-from amogilny@gmail.com) Received: by nf-out-0910.google.com with SMTP id n29so409286nfc for ; Wed, 23 Aug 2006 10:38:21 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:mime-version:content-type:content-disposition:user-agent; b=QQ202zZW1g4ApSt616gjNiOKqE+oKQq8EYSTJ7mofSfK164FrqaoK4bEgscbCexgFlsb8lRKIcebrWoNIhoV3U8PBTtodgvMXDuIx/4oT5UEC+pWWeNpVRLleJAT1TZaEfm7bCpmmZWag/GUPsNwKa02dju/rEXmsqD35fM52to= Received: by 10.49.29.2 with SMTP id g2mr2344006nfj; Wed, 23 Aug 2006 10:38:21 -0700 (PDT) Received: from localhost ( [193.28.87.193]) by mx.gmail.com with ESMTP id i1sm2774426nfe.2006.08.23.10.38.18; Wed, 23 Aug 2006 10:38:21 -0700 (PDT) Date: Wed, 23 Aug 2006 20:38:17 +0300 From: "Alexander I. Mogilny" To: freebsd-current@freebsd.org Message-ID: <20060823173817.GA37159@astral.ntu-kpi.kiev.ua> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="liOOAslEiF7prFVr" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Cc: glebius@freebsd.org, sg@astral.ntu-kpi.kiev.ua Subject: [patch] buildkernel crash [brgphy.c.patch] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2006 17:38:31 -0000 --liOOAslEiF7prFVr Content-Type: text/plain; charset=koi8-r Content-Disposition: inline I have just tried to migrate from i386 to amd64 architecture on my nx6125 laptop and failed to build kernel: make TARGET_ARCH=amd64 buildkernel error was: /usr/src/sys/dev/mii/brgphy.c: In function `brgphy_reset': /usr/src/sys/dev/mii/brgphy.c:646: error: structure has no member named `bge_no_3_led' *** Error code 1 Stop in /usr/obj/amd64/usr/src/sys/GENERIC. *** Error code 1 I have checked recent commits to bge driver and found that glebius made some changes to if_bgereg.h file which removed bge_no_3_led field from bge_softc struct. Here is the patch fixing it: --- brgphy.c.orig Wed Aug 23 20:18:28 2006 +++ brgphy.c Wed Aug 23 20:35:37 2006 @@ -643,7 +643,7 @@ PHY_WRITE(sc, BRGPHY_MII_AUXCTL, val | (1 << 15) | (1 << 4)); /* Enable Link LED on Dell boxes */ - if (bge_sc->bge_no_3_led) { + if (bge_sc->bge_flags & BGE_FLAG_NO3LED) { PHY_WRITE(sc, BRGPHY_MII_PHY_EXTCTL, PHY_READ(sc, BRGPHY_MII_PHY_EXTCTL) & ~BRGPHY_PHY_EXTCTL_3_LED); -- AIM-UANIC +-----[ FreeBSD ]-----+ Alexander Mogilny | The Power to Serve! | <> sg@portaone.com +---------------------+ --liOOAslEiF7prFVr Content-Type: text/plain; charset=koi8-r Content-Disposition: attachment; filename="brgphy.c.patch" --- brgphy.c.orig Wed Aug 23 20:18:28 2006 +++ brgphy.c Wed Aug 23 20:35:37 2006 @@ -643,7 +643,7 @@ PHY_WRITE(sc, BRGPHY_MII_AUXCTL, val | (1 << 15) | (1 << 4)); /* Enable Link LED on Dell boxes */ - if (bge_sc->bge_no_3_led) { + if (bge_sc->bge_flags & BGE_FLAG_NO3LED) { PHY_WRITE(sc, BRGPHY_MII_PHY_EXTCTL, PHY_READ(sc, BRGPHY_MII_PHY_EXTCTL) & ~BRGPHY_PHY_EXTCTL_3_LED); --liOOAslEiF7prFVr--