From owner-svn-src-all@FreeBSD.ORG  Sat Jul 12 21:06:42 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C38DFEF6;
 Sat, 12 Jul 2014 21:06:42 +0000 (UTC)
Received: from tensor.andric.com (unknown
 [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "tensor.andric.com", Issuer "CAcert Class 3 Root" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 80A2A23EE;
 Sat, 12 Jul 2014 21:06:42 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7::e050:eec9:54a7:7bdc] (unknown
 [IPv6:2001:7b8:3a7:0:e050:eec9:54a7:7bdc])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id 403825C44;
 Sat, 12 Jul 2014 23:06:34 +0200 (CEST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: svn commit: r268491 - head/usr.bin/users
From: Dimitry Andric <dim@freebsd.org>
In-Reply-To: <CAJOYFBDZiEpQ5e86+dBhRZobSjdf785bKBwh+3Eywhzn_iJJCQ@mail.gmail.com>
Date: Sat, 12 Jul 2014 23:06:33 +0200
Content-Transfer-Encoding: 7bit
Message-Id: <7E0B8EDA-7932-454B-BACC-FCA956CD012E@freebsd.org>
References: <201407101215.s6ACF3v1055260@svn.freebsd.org>
 <CAJOYFBCQjjN7ep12zivnmFjfeeP1SeoYa963mQbMJr9DD+fUnw@mail.gmail.com>
 <20140710152353.GF1812@ptrcrt.ch>
 <CAJOYFBDZiEpQ5e86+dBhRZobSjdf785bKBwh+3Eywhzn_iJJCQ@mail.gmail.com>
To: Ed Schouten <ed@80386.nl>
X-Mailer: Apple Mail (2.1878.6)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Pietro Cerutti <gahr@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Jul 2014 21:06:42 -0000

On 10 Jul 2014, at 17:29, Ed Schouten <ed@80386.nl> wrote:
> On 10 July 2014 17:23, Pietro Cerutti <gahr@freebsd.org> wrote:
>> It's because of the standard library. Examples:
>> 
>> /usr/include/c++/v1/memory:1454:47: error: unused parameter '__a'
>> [-Werror,-Wunused-parameter]
>>        static void construct(allocator_type& __a, _Tp* __p)
>> 
>> /usr/include/c++/v1/__functional_base:85:12: error: cast from 'const
>> volatile char *' to 'wchar_t *' increases required alignment from 1 to 4
>> [-Werror,-Wcast-align]
>>    return (_Tp*)&reinterpret_cast<const volatile char&>(__x);
> 
> Then I would suggest that these specific warnings (-Wunused-parameter)
> were to be disabled for C++ programs. The actual consumers should not
> have to lower their WARNS, simply because the standard library is
> broken.

IMHO it is not broken at all, but for some reason we compile everything
with -Wsystem-headers when WARNS=1 or higher. :-)

-Dimitry