From owner-svn-src-all@FreeBSD.ORG  Sat Aug 20 01:49:26 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 90BEE1065677;
	Sat, 20 Aug 2011 01:49:26 +0000 (UTC) (envelope-from scf@FreeBSD.org)
Received: from mail.farley.org (farley.org [74.218.194.34])
	by mx1.freebsd.org (Postfix) with ESMTP id 452EC8FC1B;
	Sat, 20 Aug 2011 01:49:26 +0000 (UTC)
Received: from thor.farley.org (HPooka@thor.farley.org
	[IPv6:2001:470:1f11:66f:1::5])
	by mail.farley.org (8.14.5/8.14.5) with ESMTP id p7H0cMxj015237;
	Tue, 16 Aug 2011 20:38:22 -0400 (EDT) (envelope-from scf@FreeBSD.org)
Date: Tue, 16 Aug 2011 20:38:22 -0400 (EDT)
From: "Sean C. Farley" <scf@FreeBSD.org>
To: Hans Petter Selasky <hselasky@FreeBSD.org>
In-Reply-To: <201108160834.p7G8YHiT048516@svn.freebsd.org>
Message-ID: <alpine.BSF.2.02.1108160953310.3193@thor.farley.org>
References: <201108160834.p7G8YHiT048516@svn.freebsd.org>
User-Agent: Alpine 2.02 (BSF 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
X-Spam-Status: No, score=-1.2 required=4.0 tests=AWL,BAYES_00,SPF_SOFTFAIL
	autolearn=no version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mail.farley.org
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r224903 - head/lib/libusb
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Aug 2011 01:49:26 -0000

On Tue, 16 Aug 2011, Hans Petter Selasky wrote:

> Author: hselasky
> Date: Tue Aug 16 08:34:16 2011
> New Revision: 224903
> URL: http://svn.freebsd.org/changeset/base/224903
>
> Log:
>  Add missing function to get device speed to the LibUSB v1.0 API.
>
>  MFC after:	1 week
>  Approved by:	re (kib)
>
> Modified:
>  head/lib/libusb/libusb.h
>  head/lib/libusb/libusb10.c
>
> Modified: head/lib/libusb/libusb.h
> ==============================================================================
> --- head/lib/libusb/libusb.h	Tue Aug 16 06:26:51 2011	(r224902)
> +++ head/lib/libusb/libusb.h	Tue Aug 16 08:34:16 2011	(r224903)
> @@ -151,6 +151,14 @@ enum libusb_error {
> 	LIBUSB_ERROR_OTHER = -99,
> };
>
> +enum libusb_speed {
> +	LIBUSB_SPEED_UNKNOWN = 0,
> +	LIBUSB_SPEED_LOW = 1,
> +	LIBUSB_SPEED_FULL = 2,
> +	LIBUSB_SPEED_HIGH = 3,
> +	LIBUSB_SPEED_SUPER = 4,
> +};
> +

*snip*

> +enum libusb_speed
> +libusb_get_device_speed(libusb_device *dev)
> +{
> +	if (dev == NULL)
> +		return (0);		/* should not happen */

Should that return LIBUSB_SPEED_UNKNOWN instead of 0?

Sean
-- 
scf@FreeBSD.org