Date: Mon, 8 Jun 2009 12:47:18 +0400 From: Eygene Ryabinkin <rea-fbsd@codelabs.ru> To: Hiroki Sato <hrs@FreeBSD.org> Cc: amd64@FreeBSD.org, current@FreeBSD.org Subject: Re: [head tinderbox] failure on amd64/amd64 Message-ID: <pWF1iuSxyUQ7Gt9dPKyMGS4xkXo@XX1fo6zQUfC4h0jjRC6IBz3oNH4> In-Reply-To: <yU9M2qm9rH%2BoeIVIgSzCrCakobk@j4OYE6OL8eALCd4BvSxIfwgoxSc> References: <20090608025715.499087302F@freebsd-current.sentex.ca> <8LPG99US2/4EsGlonyfMSkDb40o@XX1fo6zQUfC4h0jjRC6IBz3oNH4> <sqWp8ZLqcJhvIOZAWr3MfqIXJ9k@XX1fo6zQUfC4h0jjRC6IBz3oNH4> <20090608.165325.225640915.hrs@allbsd.org> <yU9M2qm9rH%2BoeIVIgSzCrCakobk@j4OYE6OL8eALCd4BvSxIfwgoxSc>
next in thread | previous in thread | raw e-mail | index | archive | help
And one more thing:
Mon, Jun 08, 2009 at 12:14:42PM +0400, Eygene Ryabinkin wrote:
> > if ((options | GIF_FULLOPTS) == GIF_FULLOPTS)
May be GIF_FULLOPTS is better be named GIF_OPTMASK -- it is easier to
understand what does this constant mean. A bit bikeshedy, but still...
--
Eygene
_ ___ _.--. #
\`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard
/ ' ` , __.--' # to read the on-line manual
)/' _/ \ `-_, / # while single-stepping the kernel.
`-'" `"\_ ,_.-;_.-\_ ', fsc/as #
_.-'_./ {_.' ; / # -- FreeBSD Developers handbook
{_.-``-' {_/ #
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?pWF1iuSxyUQ7Gt9dPKyMGS4xkXo>