Date: Mon, 29 Oct 2012 18:45:40 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: "Jukka A. Ukkonen" <jau@oxit.fi> Cc: freebsd-standards@freebsd.org Subject: Re: standards/170346: Changes to support waitid() and related stuff Message-ID: <20121029164540.GR73505@kib.kiev.ua> In-Reply-To: <201210131050.q9DAo1ns034926@freefall.freebsd.org> References: <201210131050.q9DAo1ns034926@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--RCJLo13VlymhPcEi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 13, 2012 at 10:50:01AM +0000, Jukka A. Ukkonen wrote: > The following reply was made to PR standards/170346; it has been noted by= GNATS. >=20 > From: "Jukka A. Ukkonen" <jau@oxit.fi> > To: bug-followup@FreeBSD.org, jau@iki.fi > Cc: =20 > Subject: Re: standards/170346: Changes to support waitid() and related st= uff > Date: Sat, 13 Oct 2012 13:38:27 +0300 >=20 > This is a multi-part message in MIME format. > --------------080903030501070905090806 > Content-Type: text/plain; charset=3DISO-8859-1; format=3Dflowed > Content-Transfer-Encoding: 7bit > =20 > =20 > Right, having said that I would stop modifying this I have to > break that promise. > I had forgotten one change which I had intended to make. > Previously the siginfo structure was zeroed inside the kernel > when wait6() returned 0. This has now been moved out of > the kernel and put inside waitid(). > Now this should be stable. I have no more planned changes > waiting to be included. > =20 > As before start with 9.1-RC2 (9-stable), apply the patch, run > =20 > ( cd /usr/src/sys/kern ; make sysent ) > ( cd /usr/src/sys/compat/freebsd32 ; make sysent ) > =20 > and build the whole system. I reviewed the patch and besides fixing enormous style violations, I also made the following changes: - The man page was mostly converted from the description of what is differe= nt with waitid(2) to just describing waitid interface as yet another functio= n. - The fix for the kernel stack content leakage from wait6. Basically, the kernel must clear the structure as the first step. - Portability fixes: Linux returns signal number in si_status. - Fixes for exported symbol list and their location. See the patch at http://people.freebsd.org/~kib/misc/waitid.1.patch Otherwise, it looks good and is almost ready to commit, e.g. it passes glibc waitid test. To be able to commit, I need a copyright text to be filled into libc/gen/waitid.c, look for XXX there. Or, at least, please specify that you agree to license the code under the 3 (or 2) clause bsd license. Thank you. --RCJLo13VlymhPcEi Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCOsrQACgkQC3+MBN1Mb4jOVwCgiXr4wgC5yZHXQJv/fP99Fkhb W1oAoN6uICd32Tc4ybh8UWnuH4LFkd33 =FUFC -----END PGP SIGNATURE----- --RCJLo13VlymhPcEi--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121029164540.GR73505>