From owner-freebsd-bugs@FreeBSD.ORG Mon Nov 10 10:00:40 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D2D416A4CE for ; Mon, 10 Nov 2003 10:00:40 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B3F2643FCB for ; Mon, 10 Nov 2003 10:00:36 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hAAI0aFY040472 for ; Mon, 10 Nov 2003 10:00:36 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hAAI0aN8040471; Mon, 10 Nov 2003 10:00:36 -0800 (PST) (envelope-from gnats) Resent-Date: Mon, 10 Nov 2003 10:00:36 -0800 (PST) Resent-Message-Id: <200311101800.hAAI0aN8040471@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefan Farfeleder Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF5A516A4CE for ; Mon, 10 Nov 2003 09:53:50 -0800 (PST) Received: from fafoe.narf.at (chello212186121237.14.vie.surfer.at [212.186.121.237]) by mx1.FreeBSD.org (Postfix) with ESMTP id BFD7A43F93 for ; Mon, 10 Nov 2003 09:53:47 -0800 (PST) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at (wombat.fafoe.narf.at [192.168.2.102]) by fafoe.narf.at (Postfix) with ESMTP id 25E0B40B6; Mon, 10 Nov 2003 18:53:45 +0100 (CET) Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id E5E691AC; Mon, 10 Nov 2003 18:53:44 +0100 (CET) Message-Id: <20031110175344.E5E691AC@wombat.fafoe.narf.at> Date: Mon, 10 Nov 2003 18:53:44 +0100 (CET) From: Stefan Farfeleder To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: stefan@fafoe.narf.at Subject: bin/59144: [patch] Allow a trailing / for mount -u too X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Stefan Farfeleder List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2003 18:00:40 -0000 >Number: 59144 >Category: bin >Synopsis: [patch] Allow a trailing / for mount -u too >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Nov 10 10:00:36 PST 2003 >Closed-Date: >Last-Modified: >Originator: Stefan Farfeleder >Release: FreeBSD 5.1-CURRENT i386 >Organization: >Environment: System: FreeBSD wombat.fafoe.narf.at 5.1-CURRENT FreeBSD 5.1-CURRENT #4: Mon Nov 10 14:51:15 CET 2003 stefan@wombat.fafoe.narf.at:/usr/home/stefan/freebsd/obj/usr/home/stefan/freebsd/src/sys/WOMBAT i386 >Description: In mount.c's revision 1.38 mount was patched to strip a trailing / from a path to "[f]ix tab completion mounts (like /cdrom/)". Annoyingly and inconsequently this is not done for the MNT_UPDATE case (mount -u). >How-To-Repeat: $ sudo mount -u /usr/ mount: not currently mounted /usr/ >Fix: --- mount.c.diff begins here --- Index: src/sbin/mount/mount.c =================================================================== RCS file: /usr/home/ncvs/src/sbin/mount/mount.c,v retrieving revision 1.54 diff -u -r1.54 mount.c --- src/sbin/mount/mount.c 7 Aug 2003 04:51:41 -0000 1.54 +++ src/sbin/mount/mount.c 10 Nov 2003 17:29:53 -0000 @@ -233,6 +233,7 @@ if (vfslist != NULL) usage(); + rmslashes(*argv, *argv); if (init_flags & MNT_UPDATE) { mntfromname = NULL; have_fstab = 0; @@ -271,7 +272,6 @@ mntbuf->f_mntonname, init_flags, options, 0); break; } - rmslashes(*argv, *argv); if ((fs = getfsfile(*argv)) == NULL && (fs = getfsspec(*argv)) == NULL) errx(1, "%s: unknown special file or file system", --- mount.c.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: