From owner-svn-ports-head@freebsd.org Fri May 8 17:12:49 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D48262DCD31; Fri, 8 May 2020 17:12:49 +0000 (UTC) (envelope-from matthias.andree@tu-dortmund.de) Received: from unimail.uni-dortmund.de (mx1.hrz.uni-dortmund.de [129.217.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "unimail.tu-dortmund.de", Issuer "DFN-Verein Global Issuing CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 49JcN03Y45z44Kv; Fri, 8 May 2020 17:12:47 +0000 (UTC) (envelope-from matthias.andree@tu-dortmund.de) Received: from mandree.no-ip.org (p54A03C0F.dip0.t-ipconnect.de [84.160.60.15]) (authenticated bits=0) by unimail.uni-dortmund.de (8.16.0.41/8.16.0.41) with ESMTPSA id 048HCjls007718 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 May 2020 19:12:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tu-dortmund.de; s=unimail; t=1588957965; bh=b+u6f0d7sgBTEkilmw59I90x9lBWh+s2fYQkZbgrQzo=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=ICWtZL8dNWmW27ll7XTJZEIu8PjInNhbUjLmJ01HujFWgB6sO/DtDe4yeGqh/vM7W dkhlRJkv83AOMlQXzEuMFRv5D6aMEAsGg8d6zoyNAhWCbS+LUY7lllUIF2ioWmnVUR MQGSXZFSe0RGG8D2EP4Th6/auruEV7qUKjW35W9I= Received: from ryzen.an3e.de (localhost [IPv6:::1]) by ryzen.an3e.de (Postfix) with ESMTP id 2FD0812026C; Fri, 8 May 2020 19:12:45 +0200 (CEST) Subject: Re: svn commit: r533459 - head/Mk/Scripts To: Mathieu Arnold , Bryan Drewery Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, "Conrad E. Meyer" References: <202004301448.03UEmMwc053196@repo.freebsd.org> <276aef88-4619-b4b7-ee92-44999b5c787d@FreeBSD.org> <20200506144056.rtx2oygw73qq7rsw@aching.in.mat.cc> From: Matthias Andree Message-ID: <90a01184-76e1-0982-950a-fdc466e1ec93@tu-dortmund.de> Date: Fri, 8 May 2020 19:12:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200506144056.rtx2oygw73qq7rsw@aching.in.mat.cc> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49JcN03Y45z44Kv X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=tu-dortmund.de header.s=unimail header.b=ICWtZL8d; dmarc=none; spf=pass (mx1.freebsd.org: domain of matthias.andree@tu-dortmund.de designates 129.217.128.51 as permitted sender) smtp.mailfrom=matthias.andree@tu-dortmund.de X-Spamd-Result: default: False [-7.13 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[tu-dortmund.de:s=unimail]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[51.128.217.129.rep.mailspike.net : 127.0.0.18]; R_SPF_ALLOW(-0.20)[+ip4:129.217.128.0/24]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[tu-dortmund.de]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; DWL_DNSWL_LOW(-1.00)[tu-dortmund.de.dwl.dnswl.org : 127.0.11.1]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-2.93)[ip: (-9.86), ipnet: 129.217.0.0/16(-4.82), asn: 680(0.05), country: DE(-0.02)]; RCVD_IN_DNSWL_MED(-0.20)[51.128.217.129.list.dnswl.org : 127.0.11.2]; DKIM_TRACE(0.00)[tu-dortmund.de:+]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:680, ipnet:129.217.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.32 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 May 2020 17:12:49 -0000 Am 06.05.20 um 16:40 schrieb Mathieu Arnold: > If you run `make patch; make makepatch` the usage would have been broken > before and still is. I think the canonical idiom should rather be make clean extract do-patch makepatch to avoid casting momentary variables from the typical post-patch REINPLACE_CMD into a new patch. > If you run `make patch makepatch`, the usage does not change, if > patching fails, it does not go into makepatch target, and if patching is > ok, then makepatch runs and updates your patches. The safe recourse after one patch failed was to fix the patch and then "make clean patch" anyways.