Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Dec 2021 10:06:09 GMT
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 56de5aeb6870 - stable/12 - After r364753, there should be no need to suppress -Watomic-alignment warnings anymore for compiler-rt's atomic.c. This occurred because the IS_LOCK_FREE_8 macro was not correctly defined to 0 for mips, and this caused the compiler to emit a runtime call to __atomic_is_lock_free(), and that triggers the warning.
Message-ID:  <202112221006.1BMA69t4092305@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by dim:

URL: https://cgit.FreeBSD.org/src/commit/?id=56de5aeb6870e644b9306518fdf1fcc180461eba

commit 56de5aeb6870e644b9306518fdf1fcc180461eba
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2020-08-25 19:57:11 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2021-12-22 10:01:13 +0000

    After r364753, there should be no need to suppress -Watomic-alignment
    warnings anymore for compiler-rt's atomic.c. This occurred because the
    IS_LOCK_FREE_8 macro was not correctly defined to 0 for mips, and this
    caused the compiler to emit a runtime call to __atomic_is_lock_free(),
    and that triggers the warning.
    
    MFC after:      2 weeks
    X-MFC-With:     r364753
    
    (cherry picked from commit 0709bb1f4146361e7917201a2438e1b2cd36f40b)
---
 lib/libcompiler_rt/Makefile.inc | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/lib/libcompiler_rt/Makefile.inc b/lib/libcompiler_rt/Makefile.inc
index 217ea4da0049..5766e835ea38 100644
--- a/lib/libcompiler_rt/Makefile.inc
+++ b/lib/libcompiler_rt/Makefile.inc
@@ -1,7 +1,5 @@
 # $FreeBSD$
 
-.include <bsd.compiler.mk>
-
 CRTARCH=	${MACHINE_CPUARCH:C/amd64/x86_64/}
 
 CRTSRC=		${SRCTOP}/contrib/llvm-project/compiler-rt/lib/builtins
@@ -131,10 +129,6 @@ SRCF+=		umodti3
 SRCF+=		atomic
 .endif
 
-.if "${COMPILER_TYPE}" == "clang"
-CFLAGS.atomic.c+=      -Wno-atomic-alignment
-.endif
-
 # Avoid using SSE2 instructions on i386, if unsupported.
 .if ${MACHINE_CPUARCH} == "i386" && empty(MACHINE_CPU:Msse2)
 SRCS+=		floatdidf.c



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202112221006.1BMA69t4092305>