From nobody Mon Oct 2 14:32:06 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rzk1X1cZSz4w87L; Mon, 2 Oct 2023 14:32:16 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rzk1X1C15z3dV0; Mon, 2 Oct 2023 14:32:16 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696257136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cWD9FljEZyM2hTfh534tZIMs2asjawHFVPq62pmT5kk=; b=pZynMQlRAp/IyxTWcPeeBB9/XbIMugsGVniaDqqnmo7ueMBp6Aj+HPw0V3JEZOCQbsurB3 haqBJ0XjBWFQAaHyD4APKLuk6mMRBpMc38Hga5m2vJTEScn/UwJsnYRl7WojlzVOVopqRi Ly0FuBinE9BrPva1WRHTq+5GDewdkmwREj9hcxvP+n6/DNTvvgDMzBYU+1wVyJqzCoC12U Bun8N2okUvlKMkIzUx0s6qzoY4UEzZ6nDXWknHPdQt95gtaIjHRoHnJIVZlptQZkgOXaFG Kbj+UwmiJob0g1e0DKRpIthYA3bMWz4GrXehGPBSzXi5Xv9lTW66sqtT86r7eQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696257136; a=rsa-sha256; cv=none; b=aTWxPGJ6NBE62o+0XsOgRRARBzhevxLUNrYLY20PxZVQML9c9OTCqbOo7WEIQ5duV/5BzF ArbM9zz8Ov3C9llwPoHVjsnIS1L30rZU0cZz6r0c+DqdwKbQEi3Ok2tjPY49NXjgjjS/on H5BMtJNhJMjXnbqItsPwzDxmcjURJZeS8/95JAw8K1FOZrqWu0U5NlDzDVgwim64/RuAU9 OxNWb7Dzo0b6OCzOkj3qfovZoylESZCotX7BVRpuiP8kWPYessgorBzY35Yd63m/QJI26M D2ZVoPy9dopr4iu6jjWYRCYIHVQfvWLgUrV1agS7D/zigvG4xmheDo6msRO5yw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696257136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cWD9FljEZyM2hTfh534tZIMs2asjawHFVPq62pmT5kk=; b=iUCKjuv17gIXKG0KLfy5hFlMn9Nu3kAfDm7DVPO6QK6lpse7iLHSNe/QJjM3n+OdgOyURF A1mhp4yUsbFPNzDuRR9De1DLxwvv3Pn5pn5tWS0SSZEpK8G8isu/1ToIFMtfviAc3ZIOi6 k9gWwwDnybNdIXgTtUuG/jsMG/s9+wLI7lOCE1irfYVJZgOKTATBM/QWYbT5ijy3jMR9b2 ot8U+GIkbsEOIafz9BLM5QFG0vNbO8ZRWm9rzRGNzhocblHnmR6e+u2obY5dund3OEqpgo CnVwM+VKyrttJrPVYsc72j1YcAA73yuUAzfZUD6nfCAG3aA9M/qHetHl66HLFg== Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Rzk1V3kGYzqh; Mon, 2 Oct 2023 14:32:14 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: git: a9359dcde241 - stable/14 - ipfilter: Add sysctl flag CTLFLAG_TUN to loader tunable From: Zhenlei Huang In-Reply-To: <20231002025315.41C99A7C@slippy.cwsent.com> Date: Mon, 2 Oct 2023 22:32:06 +0800 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-branches@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202310020050.3920omhH029460@gitrepo.freebsd.org> <20231002025315.41C99A7C@slippy.cwsent.com> To: Cy Schubert X-Mailer: Apple Mail (2.3696.120.41.1.4) > On Oct 2, 2023, at 10:53 AM, Cy Schubert = wrote: >=20 > In message <202310020050.3920omhH029460@gitrepo.freebsd.org>, Zhenlei = Huang=20 > wri > tes: >> The branch stable/14 has been updated by zlei: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Da9359dcde241f17421a71bc8c96dee08= >> 625db9dd >>=20 >> commit a9359dcde241f17421a71bc8c96dee08625db9dd >> Author: Zhenlei Huang >> AuthorDate: 2023-09-29 00:01:43 +0000 >> Commit: Zhenlei Huang >> CommitDate: 2023-10-02 00:49:38 +0000 >>=20 >> ipfilter: Add sysctl flag CTLFLAG_TUN to loader tunable >>=20 >> The sysctl variable `net.inet.ipf.large_nat` is actually a loader >> tunable. Add sysctl flag CTLFLAG_TUN to it so that `sysctl -T` = will >> report it correctly. >>=20 >> No functional change intended. >>=20 >> Reviewed by: cy (for #network) >> Fixes: a805ffbcbce8 ipfilter: Make LARGE_NAT a tunable >> MFC after: 3 days >> Differential Revision: https://reviews.freebsd.org/D42005 >>=20 >> (cherry picked from commit = ba883e7a5ac43b27a373f2b1b0044fd2eb769d4e) >> --- >> sys/netpfil/ipfilter/netinet/mlfk_ipl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/sys/netpfil/ipfilter/netinet/mlfk_ipl.c = b/sys/netpfil/ipfilter/n >> etinet/mlfk_ipl.c >> index 35daad4715bf..69be4abb2485 100644 >> --- a/sys/netpfil/ipfilter/netinet/mlfk_ipl.c >> +++ b/sys/netpfil/ipfilter/netinet/mlfk_ipl.c >> @@ -134,7 +134,7 @@ SYSCTL_IPF(_net_inet_ipf, OID_AUTO, fr_running, = CTLFLAG_R >> D, >> &VNET_NAME(ipfmain.ipf_running), 0, "IPF is running"); >> SYSCTL_IPF(_net_inet_ipf, OID_AUTO, fr_chksrc, CTLFLAG_RW, = &VNET_NAME(ipfmai >> n.ipf_chksrc), 0, ""); >> SYSCTL_IPF(_net_inet_ipf, OID_AUTO, fr_minttl, CTLFLAG_RW, = &VNET_NAME(ipfmai >> n.ipf_minttl), 0, ""); >> -SYSCTL_IPF(_net_inet_ipf, OID_AUTO, large_nat, CTLFLAG_RD, = &VNET_NAME(ipfmai >> n.ipf_large_nat), 0, "large_nat"); >> +SYSCTL_IPF(_net_inet_ipf, OID_AUTO, large_nat, CTLFLAG_RDTUN | = CTLFLAG_NOFET >> CH, &VNET_NAME(ipfmain.ipf_large_nat), 0, "large_nat"); >>=20 >> #define CDEV_MAJOR 79 >> #include >>=20 >=20 > Can you also please MFC to stable/13 and 12? Done! Well, I just have a ( long ) break after MFCing to stable/14 ;) >=20 >=20 > --=20 > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org >=20 > e^(i*pi)+1=3D0 >=20 >=20 >=20 > X-B=C2=9D=C4=B6=17