From owner-freebsd-current@FreeBSD.ORG  Wed Jun 30 18:46:28 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A5E56106566B
	for <freebsd-current@freebsd.org>; Wed, 30 Jun 2010 18:46:28 +0000 (UTC)
	(envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
	by mx1.freebsd.org (Postfix) with ESMTP id 644D18FC08
	for <freebsd-current@freebsd.org>; Wed, 30 Jun 2010 18:46:28 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 2FC911FFC33;
	Wed, 30 Jun 2010 18:46:27 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id B147E845D8; Wed, 30 Jun 2010 20:44:15 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Tom Evans <tevans.uk@googlemail.com>
References: <AANLkTinn5bPXDf-tRIlpGCp3iFgtYi20mzRSbqkBcj6b@mail.gmail.com>
	<20100621101046.GA76036@droso.net>
	<AANLkTilhgzVDFX9MGQTS_DzJt_5QtlaNF--nQss-5mzj@mail.gmail.com>
	<20100621130743.4df77343@ernst.jennejohn.org>
	<AANLkTikrXvx_3Y7nkceaKSYqLQemGrIBURt1-5pwl6qr@mail.gmail.com>
	<AANLkTinxzijyXsAQIdf75cw-GeRH_Wd1E8zIYmU-Xlfd@mail.gmail.com>
Date: Wed, 30 Jun 2010 20:44:15 +0200
In-Reply-To: <AANLkTinxzijyXsAQIdf75cw-GeRH_Wd1E8zIYmU-Xlfd@mail.gmail.com>
	(Tom Evans's message of "Wed, 30 Jun 2010 14:47:55 +0100")
Message-ID: <86pqz8mkcg.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-current <freebsd-current@freebsd.org>
Subject: Re: Ports doesnt respect fetch environment settings
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jun 2010 18:46:28 -0000

Tom Evans <tevans.uk@googlemail.com> writes:
> Sorry to bump this again. I've diluted this issue down to the core
> points and raised as a pr - can someone take a look, see if my
> solution is correct and commit if appropriate?

Sorry, fell through the cracks.  Your analysis is correct, but I'm not
100% sure about the patch.  Can you verify that your change does not
introduce the possibility of an infinite loop in edge cases?  I don't
*think* it does, but like I said, I'm not 100% sure and I don't have
time to reacquaint myself with the code right now, especially not that
particularly nasty part of it :)

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no