From owner-cvs-all@FreeBSD.ORG Tue Jan 24 23:05:16 2012 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 6965A106566B; Tue, 24 Jan 2012 23:05:16 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-150-251.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 3E7351507E4; Tue, 24 Jan 2012 23:05:16 +0000 (UTC) Message-ID: <4F1F392C.9040807@FreeBSD.org> Date: Tue, 24 Jan 2012 15:05:16 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120119 Thunderbird/9.0 MIME-Version: 1.0 To: Michael Scheidell References: <201201241915.q0OJFFkq063511@repoman.freebsd.org> In-Reply-To: <201201241915.q0OJFFkq063511@repoman.freebsd.org> X-Enigmail-Version: 1.3.5 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, Jarrod Sayers , Gabor Kovesdan , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/audio/shoutcast Makefile distinfo pkg-plist ports/audio/shoutcast/files pkg-message.in shoutcast.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2012 23:05:16 -0000 On 01/24/2012 11:15, Michael Scheidell wrote: > scheidell 2012-01-24 19:15:15 UTC > > FreeBSD ports repository > > Modified files: > audio/shoutcast Makefile distinfo pkg-plist > audio/shoutcast/files pkg-message.in shoutcast.in > Log: > - Update to 2.0.0.29. > - Bump from beta (build 14) to release (build 29) > - Resolve oddities surrounding PLIST_SUB and SUB_LIST (thanks Michael and Gabor) > - Update pkg-plist to reflect updated documentation > - Support creation of both sc_serv.log and sc_w3c.log on startup > > PR: ports/16440 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=16440 This is not the right PR number. Also, you need "Submitted by:" here. As for the change to the rc.d script itself, it removes the optimization of: required_files="${shoutcast_configfile:="%%PREFIX%%/%%ETCDIR%%/sc_serv.conf"}" which isn't the end of the world if that's what the maintainer wants. (Same goes for changing the literal shoutcast to $name.) However it also removed the required_dirs="${shoutcast_chdir}" which is probably not a good idea. Also, %%SHOUTCASTUSER%% in the chown line should be ${shoutcast_user} but I think that was probably a bug in my previous patch, so sorry about that. However, the touch/chown/chmod lines add "" around each variable, which is almost certainly unnecessary. A better way to handle this situation (substantial changes to the script by the maintainer after it was already changed by another developer) would have been to start a dialog about the changes before committing them. Ideally on the freebsd-rc@ or freebsd-ports@ lists. Doug > Approved by: gabor (mentor) > > Revision Changes Path > 1.22 +11 -10 ports/audio/shoutcast/Makefile > 1.9 +2 -2 ports/audio/shoutcast/distinfo > 1.4 +1 -1 ports/audio/shoutcast/files/pkg-message.in > 1.3 +15 -12 ports/audio/shoutcast/files/shoutcast.in > 1.4 +3 -1 ports/audio/shoutcast/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/shoutcast/Makefile.diff?&r1=1.21&r2=1.22&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/shoutcast/distinfo.diff?&r1=1.8&r2=1.9&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/shoutcast/files/pkg-message.in.diff?&r1=1.3&r2=1.4&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/shoutcast/files/shoutcast.in.diff?&r1=1.2&r2=1.3&f=u > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/shoutcast/pkg-plist.diff?&r1=1.3&r2=1.4&f=u > -- It's always a long day; 86400 doesn't fit into a short. Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/