From owner-cvs-ports@FreeBSD.ORG  Mon Apr 13 16:55:26 2009
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9831F106577B;
	Mon, 13 Apr 2009 16:55:26 +0000 (UTC)
	(envelope-from wxs@atarininja.org)
Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.60.158])
	by mx1.freebsd.org (Postfix) with ESMTP id 64D958FC08;
	Mon, 13 Apr 2009 16:55:25 +0000 (UTC)
	(envelope-from wxs@atarininja.org)
Received: by syn.atarininja.org (Postfix, from userid 1001)
	id 156225C3B; Mon, 13 Apr 2009 12:55:25 -0400 (EDT)
Date: Mon, 13 Apr 2009 12:55:25 -0400
From: Wesley Shields <wxs@FreeBSD.org>
To: Ion-Mihai Tetcu <itetcu@FreeBSD.org>
Message-ID: <20090413165524.GE48814@atarininja.org>
References: <200904130953.n3D9rSjT038689@repoman.freebsd.org>
	<20090413110842.D60498FC3B@release.ixsystems.com>
	<20090413124252.GB48814@atarininja.org>
	<20090413164306.54d5af3a@it.buh.tecnik93.com>
	<20090413140429.GD48814@atarininja.org>
	<20090413193822.23a64432@it.buh.tecnik93.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090413193822.23a64432@it.buh.tecnik93.com>
User-Agent: Mutt/1.5.19 (2009-01-05)
Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, QAT@FreeBSD.org,
	cvs-all@FreeBSD.org, gahr@FreeBSD.org
Subject: Re: cvs commit: ports/lang/q Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Apr 2009 16:55:29 -0000

On Mon, Apr 13, 2009 at 07:38:22PM +0300, Ion-Mihai Tetcu wrote:
> On Mon, 13 Apr 2009 10:04:29 -0400
> Wesley Shields <wxs@FreeBSD.org> wrote:
> 
> > On Mon, Apr 13, 2009 at 04:43:06PM +0300, Ion-Mihai Tetcu wrote:
> > > On Mon, 13 Apr 2009 08:42:52 -0400
> > > Wesley Shields <wxs@FreeBSD.org> wrote:
> > > 
> > > > On Mon, Apr 13, 2009 at 04:08:42AM -0700, QAT@FreeBSD.org wrote:
> > > > > The Restless Daemon identified a PLIST error while trying to
> > > > > build: q-7.11 maintained by gahr@FreeBSD.org
> > > > >  Makefile ident: $FreeBSD: ports/lang/q/Makefile,v 1.35
> > > > > 2009/04/13 09:53:27 gahr Exp $
> > > > > 
> > > > > Excerpt from
> > > > > http://QAT.TecNik93.com/logs/7-STABLE-FPT-NPD/q-7.11.log :
> > > > 
> > > > [...]
> > > > 
> > > > This looks like a false positive to me.
> > > 
> > > It wasn't. There was a second commit that fixed the problem probably
> > > while the port was building.
> > 
> > Ah, and by the time I got to see the log it was fixed.  Thanks.
> 
> Yup.
> 
> > > > On a related note, how does QAT handle MAKE_JOBS_SAFE?  Does it
> > > > manage to find the error which could have been much earlier in
> > > > the log?
> > > 
> > > QAT has 4 CPUs so it builds with multiple make jobs if the ports
> > > says so. There's no supplementary analyses being done, if the build
> > > doesn't exit when one of the jobs fails (as it should), the error
> > > would be catch at install or packaging time.
> > 
> > But then the log excerpt in the email may not actually contain the
> > error.
> 
> The excerpt is just a tail on the last lines of the log; usually it
> catches the error; I could try to do a little heuristics, but I'm not
> that sure of the results (I'd use the markup patters used by webui).

OK, that's what I thought.  I'm not suggesting that be done, but just
that it's a known thing (I hesitate to even call it a problem).

> Anyway, the log snippet is intended to hint the problem and any
> responsible commit implies reviewing the hole log.

Absolutely.

-- WXS