From owner-freebsd-fs@FreeBSD.ORG Thu Dec 4 10:51:34 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 503BA1065678; Thu, 4 Dec 2008 10:51:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id E062B8FC16; Thu, 4 Dec 2008 10:51:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1L8Bnw-0005Kj-NG; Thu, 04 Dec 2008 12:51:32 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id mB4ApTZa061830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 4 Dec 2008 12:51:30 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id mB4ApTum025259; Thu, 4 Dec 2008 12:51:29 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id mB4ApTom025258; Thu, 4 Dec 2008 12:51:29 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 4 Dec 2008 12:51:29 +0200 From: Kostik Belousov To: "Bruce M. Simpson" Message-ID: <20081204105129.GA2246@deviant.kiev.zoral.com.ua> References: <8cb6106e0811241129o642dcf28re4ae177c8ccbaa25@mail.gmail.com> <20081125140601.GH2042@deviant.kiev.zoral.com.ua> <8cb6106e0811250617q5fffb41exe20dfb8314fc4a9d@mail.gmail.com> <20081125142827.GI2042@deviant.kiev.zoral.com.ua> <8cb6106e0811250657q6fdf08b0x1e94f35fd0a7ed4f@mail.gmail.com> <20081125150342.GL2042@deviant.kiev.zoral.com.ua> <8cb6106e0812031453j6dc2f2f4i374145823c084eaa@mail.gmail.com> <49378379.5050900@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: <49378379.5050900@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1L8Bnw-0005Kj-NG 247ecf99707698ec13432c25c35defde X-Terabit: YES Cc: josh.carroll@gmail.com, freebsd-fs@freebsd.org, FreeBSD Stable Subject: Re: ext2 inode size patch - RE: PR kern/124621 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2008 10:51:34 -0000 --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 04, 2008 at 07:15:05AM +0000, Bruce M. Simpson wrote: > Hi, >=20 > The inode size for the ext3 filesystem which Gentoo created for my last= =20 > install defaulted to 256 bytes, so I got bit by this problem. >=20 > I can't speak for the write path. but the read path looks just fine to=20 > me, and the patch should go in ASAP. >=20 > Josh Carroll wrote: > >>Ok, I describe my concern once more. I do not object against the checki= ng > >>of the inode size. But, if inode size is changed, then some data is add= ed > >>to the inode, that could (and usually does, otherwise why extend it ?) > >>change intrerpetation of the inode. Thus, we need a verification of the > >>fact that simply ignoring added fields does not damage filesystem or > >>cause user data corruption. Verification !=3D testing. > >> =20 >=20 > If folk are paranoid, then add a check for dynamic inode size and=20 > disable ext2fs writes by downgrading the mount in that case (We can do=20 > that, right? Can someone make sure Josh gets the help he needs here?) >=20 > As Josh points out, the ext2 inode size is stored in the superblock.=20 > Whilst it may vary between ext2 filesystems, *the inode size itself does= =20 > not appear to be something which one can modify in an existing ext2/3=20 > filesystem*. >=20 > Older ext2 filesystems may not contain the inode size field in the=20 > superblock, and the patch appears to default to 128 for that case. The=20 > double indirection thus introduced doesn't concern me, our ext2fs is not= =20 > performance critical code, and the superblock is likely to sit in L2/L3= =20 > cache anyway (note: content free argument). >=20 > Thanks to Josh for fixing this problem. Bruce, feel free to commit the patch. I do not want to spend time on ext2 in any form, and due to our (only partly jokingly) rule of the "last committer is the owner", I do not want to analyze ext2 bug reports after. --17pEHd4RhPHOinZp Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkk3tjEACgkQC3+MBN1Mb4gsMACfdZOmzO3B2qwkehgi1lWJWB+s anMAoNKxfWj1QQ6gOIYnXXIRE6bPZeWs =8ohK -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp--