From owner-cvs-all@FreeBSD.ORG  Mon Aug 25 12:06:19 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0D7A416A4BF; Mon, 25 Aug 2003 12:06:19 -0700 (PDT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 56AF843F75; Mon, 25 Aug 2003 12:06:17 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h7PJ6CNj091830;
	Mon, 25 Aug 2003 21:06:13 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: Marcel Moolenaar <marcel@xcllnt.net>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Mon, 25 Aug 2003 12:03:50 PDT."
             <20030825190349.GC18841@ns1.xcllnt.net> 
Date: Mon, 25 Aug 2003 21:06:12 +0200
Message-ID: <91829.1061838372@critter.freebsd.dk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: John Baldwin <jhb@FreeBSD.org>
Subject: Re: cvs commit: src/sys/vm vm_page.h 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Aug 2003 19:06:19 -0000

In message <20030825190349.GC18841@ns1.xcllnt.net>, Marcel Moolenaar writes:
>On Mon, Aug 25, 2003 at 01:38:36PM -0400, John Baldwin wrote:
>> 
>> On 23-Aug-2003 Marcel Moolenaar wrote:
>> > marcel      2003/08/22 23:24:00 PDT
>> > 
>> >   FreeBSD src repository
>> > 
>> >   Modified files:
>> >     sys/vm               vm_page.h 
>> >   Log:
>> >   Add support for 16K and 32K page sizes. The valid and dirty maps
>> >   in struct vm_page are defined as u_int for 16K pages and u_long
>> >   for 32K pages, with the implied assumption that long will at least
>> >   be 64 bits wide on platforms where we support 32K pages.
>> 
>> Why not use 'uint32_t' and 'uint64_t' to remove the assumption?
>
>I thought about that but decided not to do it because it would
>introduce a style variation that I considered worse than having
>the implied assumption.

Mark the assumption with a CTASSERT ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.