From owner-svn-src-head@FreeBSD.ORG Thu Dec 2 05:16:06 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C2EB10656A3; Thu, 2 Dec 2010 05:16:06 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 79B148FC19; Thu, 2 Dec 2010 05:16:05 +0000 (UTC) Received: by wyf19 with SMTP id 19so7757449wyf.13 for ; Wed, 01 Dec 2010 21:16:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:content-type:content-transfer-encoding; bh=O/hGI7o6p7qbPaER3NwvbDHU2PkSk8ufderTEfk7yII=; b=FKzvdTYz2dIhOcj/zSbMTLSz0/Wfjyp4ujLfU+x0++fLrMZl+2OmiwkUd6uBMQ8Kxn enStKsbms6WGKbn9sTKDjBY52w2/nxjwPnaiy4vnW7wDtn6BgNsKYIJi8wN7eskc8IYA rI/FAfjnwkKTPjD9fQmnMxJuIH5oZI4yr7XNE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=jmVuI/3MYfudI2TyKvu/5AvRaeFxgREVMuE/GYfKHEzDhM/KhnnHDofwa9FcghAcMd hGqFrJk9q0rI/96UDKizEi4uqOXICTE34OAvAdfcPcOF1bqrTb9B+IkYB+RsHPiSY7N+ rfFzyupWrxXEiDq64Nq3ShXlLHR3yfRqfV97g= MIME-Version: 1.0 Received: by 10.216.71.209 with SMTP id r59mr1068789wed.15.1291266964057; Wed, 01 Dec 2010 21:16:04 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.198.27 with HTTP; Wed, 1 Dec 2010 21:16:04 -0800 (PST) In-Reply-To: <20101202045728.GA19295@zim.MIT.EDU> References: <201006121732.o5CHW5Cs065722@svn.freebsd.org> <20100615084939.GL13238@deviant.kiev.zoral.com.ua> <20100615131443.GA93094@zim.MIT.EDU> <20101202045728.GA19295@zim.MIT.EDU> Date: Wed, 1 Dec 2010 21:16:04 -0800 X-Google-Sender-Auth: xfMeC5F0YV4lQVR_LXivyl36v-o Message-ID: From: Garrett Cooper To: Kostik Belousov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Subject: Re: svn commit: r209110 - in head/lib/msun: . src X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2010 05:16:06 -0000 On Wed, Dec 1, 2010 at 8:57 PM, David Schultz wrote: > On Tue, Jun 15, 2010, David Schultz wrote: >> On Tue, Jun 15, 2010, Kostik Belousov wrote: >> > On Sat, Jun 12, 2010 at 05:32:05PM +0000, David Schultz wrote: >> > > Author: das >> > > Date: Sat Jun 12 17:32:05 2010 >> > > New Revision: 209110 >> > > URL: http://svn.freebsd.org/changeset/base/209110 >> > > >> > > Log: >> > > =A0 Introduce __isnanf() as an alias for isnanf(), and make the isna= n() >> > > =A0 macro expand to __isnanf() instead of isnanf() for float argumen= ts. >> > > =A0 This change is needed because isnanf() isn't declared in strict = POSIX >> > > =A0 or C99 mode. >> > > >> > > =A0 Compatibility note: Apps using isnan(float) that are compiled af= ter >> > > =A0 this change won't link against an older libm. >> > > >> > > =A0 Reported by: =A0 =A0Florian Forster >> > >> > May be, it makes sense to remove the default version for the isnan sym= bol ? >> >> Wouldn't this mean apps that use isnanf() directly will no longer >> compile? =A0isnanf() is a historical BSD interface, and although >> it's been deprecated for many years, it's still declared (if >> __BSD_VISIBLE). >> >> Oops, to complicate matters further, I just noticed that we >> already have isnanf and __isnanf symbols in libc, so maybe the new >> symbol isn't needed. =A0(isnan() and isnanf() are in libc because >> that's where they were historically.) =A0The second version in >> libm looks like a mistake (wrong scope of the #if 0 in s_isnan.c.) >> Perhaps we could just remove the duplicate symbols from libm. > > Any thoughts on removing the isnanf and __isnanf symbols from > libm? =A0Both symbols are already in libc for historical reasons, so > the duplication isn't needed. > > Although we've had the duplicate isnanf symbol in libm for several > releases, I don't believe removing it will cause problems; apps > will just pick up the libc version. =A0__isnanf is only present in > libm in 9-CURRENT (due to the commit referenced above). =A0Because > of symbol version differences, however, removing it will affect > apps that were linked under 9-CURRENT AND rely on isnanf AND link > against libm before libc. =A0On my system, libwebkit is the only > affected binary I could find. Yeah... it's going to be broken according to the manpage (manpage explicitly calls out -lm and math.h) and POSIX (POSIX only calls out math.h) as math.h lives in lib/msun for C apps: $ find /usr/src/ -name math.h /usr/src/contrib/libstdc++/include/tr1/math.h /usr/src/contrib/libstdc++/include/c_compatibility/math.h /usr/src/lib/msun/src/math.h So unless math.h is going to move to libc, I'd leave it alone if I was making the final call. Thanks, -Garrett