From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Mar 3 11:20:04 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4D3A1065675 for ; Tue, 3 Mar 2009 11:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 832088FC1B for ; Tue, 3 Mar 2009 11:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n23BK48c087989 for ; Tue, 3 Mar 2009 11:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n23BK4Oo087988; Tue, 3 Mar 2009 11:20:04 GMT (envelope-from gnats) Resent-Date: Tue, 3 Mar 2009 11:20:04 GMT Resent-Message-Id: <200903031120.n23BK4Oo087988@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Timothy Beyer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1EF51065673 for ; Tue, 3 Mar 2009 11:15:57 +0000 (UTC) (envelope-from beyert@cs.ucr.edu) Received: from sentoku.ucr.edu (sentoku.ucr.edu [138.23.214.80]) by mx1.freebsd.org (Postfix) with ESMTP id 9AAF58FC1C for ; Tue, 3 Mar 2009 11:15:57 +0000 (UTC) (envelope-from beyert@cs.ucr.edu) Received: from aeonserv.aeonnet (cpe-76-90-217-240.socal.res.rr.com [76.90.217.240]) by sentoku.ucr.edu (MOS 3.10.3-GA) with ESMTP id ECJ00095 (AUTH tbeye001); Tue, 3 Mar 2009 03:15:56 -0800 (PST) Message-Id: <87myc2g8ld.wl%beyert@cs.ucr.edu> Date: Tue, 03 Mar 2009 03:16:14 -0800 From: Timothy Beyer To: FreeBSD-gnats-submit@FreeBSD.org Cc: Timothy Beyer Subject: ports/132280: audio/snd: Fix guile support, add motif support X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2009 11:20:04 -0000 >Number: 132280 >Category: ports >Synopsis: audio/snd: Fix guile support, add motif support >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Mar 03 11:20:04 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Timothy Beyer >Release: FreeBSD 7.1-RELEASE-p2 i386 >Organization: no organization >Environment: System: FreeBSD aeonserv.aeonnet 7.1-RELEASE-p2 FreeBSD 7.1-RELEASE-p2 #4: Sun Jan 25 21:45:53 PST 2009 beyert@aeonserv.aeonnet:/usr/obj/usr/src/sys/CUSTOM i386 >Description: This patch makes the following changes: -Adds --with-guile so that guile is actually enabled when guile is selected (currently, if guile is selected, it doesn't install any extension language -- this is because snd's default extension language is now s7) -Adds support for Motif (the X11 option is now decoupled from GTK, if GTK support is desired, use the GTK and the X11 knobs; Similarly, if Motif is desired, select both the X11 and Motif options.) On a side note, currently if S7 support is enabled, snd will not compile. If I come up with a patch, I will file a PR. Please don't disable the option; I think it will become the only scheme supported eventually, so fixing it should be an eventual priority. >How-To-Repeat: -Enable guile and run snd --help after snd is installed -Enable X11 and GTK or X11 and Motif -Try enabling the S7 option (it won't compile) >Fix: The following patches: --- Makefile.diff begins here --- --- Makefile.orig 2009-02-27 15:30:14.000000000 -0800 +++ Makefile 2009-03-03 02:32:39.000000000 -0800 @@ -22,7 +22,9 @@ LADSPA "Include support for LADSPA plugins" on \ NLS "Native Language Support" on \ RUBY "Use Ruby as the extension language" off \ - X11 "Make Snd with Gtk+ graphics support" on + MOTIF "Make Snd with Motif graphics support" on \ + GTK "Make Snd with Gtk+ graphics support" off \ + X11 "Make Snd with GUI support" on USE_GNOME= gnometarget GNU_CONFIGURE= yes @@ -61,6 +63,7 @@ .endif .if !defined(WITHOUT_GUILE) +CONFIGURE_ARGS+= --with-guile LIB_DEPENDS+= guile.20:${PORTSDIR}/lang/guile PLIST_SUB+= SCHEME="" .else @@ -96,14 +99,20 @@ PLIST_SUB+= SCHEME="@comment " .endif -.if defined(WITHOUT_X11) -CONFIGURE_ARGS+= --with-no-gui -PLIST_SUB+= X11="@comment " -.else +.if defined(WITH_GTK) USE_GNOME+= gtk20 CONFIGURE_ARGS+= --with-gtk PLIST_SUB+= X11="" .endif +.if defined(WITH_MOTIF) +CONFIGURE_ARGS+= --with-motif +PLIST_SUB+= X11="" +.endif + +.if defined(WITHOUT_X11) +CONFIGURE_ARGS+= --with-no-gui +PLIST_SUB+= X11="@comment " +.endif post-patch: @${REINPLACE_CMD} -e 's|^ _Complex| Vaiolate _Complex|g ; \ --- Makefile.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: