From owner-svn-src-head@freebsd.org Sun Jan 14 17:13:34 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77E73E7B451; Sun, 14 Jan 2018 17:13:34 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pl0-x231.google.com (mail-pl0-x231.google.com [IPv6:2607:f8b0:400e:c01::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 43D89396; Sun, 14 Jan 2018 17:13:34 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pl0-x231.google.com with SMTP id q3so2085566plr.8; Sun, 14 Jan 2018 09:13:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lXDkBDpkE5KSsMdMDAcT/wQT1VdBnE40P1S0IQFdjn4=; b=hYr+gSRPixnsjM8nUUExDPQAWSm61+o/KdbToLg4pdmj0YCsKfxEyAsCUl+i9G3Etw j2zj3vw8QmEr+L47nDslE0/BZNtUVz0FAjEj4YWv1WDo7K39QoRx7asiAC9QEomDplBU r0Ln9SCyi/Pwl9ITSXvCnfasyey2F/siG0QiZrHS8jaW07y8M+bLrC0u1ADQ8sr6TAYy z5qJwUqR5h9DwS6aUtNtES9Lm71pz2ZEJA8G1k/NpfVmQ5qweypm5o+pyNsSkDZ82XKC ZGOeIwvOeLPqKTfjh+2Hc+Go9UnVxCZhytYw70mdM7WYTetld4jAPfAybxKlsb7uw2Bk 1qnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=lXDkBDpkE5KSsMdMDAcT/wQT1VdBnE40P1S0IQFdjn4=; b=meXTbLhI5szXnqrE9aAkOKQkpHM8SspwyETf/NYmesCe169IWzFpFrzWuZPqBGXyRr xqa8CJmVLb/uPS3KngIbuBd5x4zdRXnwgzmBgINyZWEl7rzQyTo4ieJEWCv99tULMARD lfNEWVb1EzsdX09CD/pU/A1i0E2wqfmhtuGDys4mR2U0n+B2EtYtbzsnAdkQ/zGtcN6k HWcHl4fLaXjuakgFY+Epkev+YJrasDBueM5biFfpcSwBXqkUVZXxDW5qlG9XdTNCgGJa 1SqmeWB5PdOx5dMRitXwKqj2xYtS7QZdv+3DZ6MJEf9eBSVgYKnZPQFgKhcnqIg8tn6B nRMw== X-Gm-Message-State: AKwxytcGVXP+/7Y184GHgs8Pzptv9dEP/N2f2Quw6BlOiVsBdm7K+MSB vCHAtOXwKqoScFV9TIBY5r8= X-Google-Smtp-Source: ACJfBovNYIX9AiVh47xy7uEUSw9zQrIipk3WE1HBjtkJLPiUA/cXILxG9zWlQ9NlIZ/J8jRhv5wc4w== X-Received: by 10.84.234.199 with SMTP id i7mr1436442plt.368.1515950013577; Sun, 14 Jan 2018 09:13:33 -0800 (PST) Received: from raichu (toroon0560w-lp140-02-70-49-169-112.dsl.bell.ca. [70.49.169.112]) by smtp.gmail.com with ESMTPSA id u79sm32284591pfg.141.2018.01.14.09.13.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jan 2018 09:13:32 -0800 (PST) Sender: Mark Johnston Date: Sun, 14 Jan 2018 12:13:27 -0500 From: Mark Johnston To: Mateusz Guzik Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327888 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/safety cddl/contrib/opensolaris/lib/libdtrace/common cddl/usr.sbin/dtrace/tests/common/safety sys/cddl/contrib/ope... Message-ID: <20180114171327.GA89171@raichu> References: <201801121959.w0CJxlaw010074@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jan 2018 17:13:34 -0000 On Fri, Jan 12, 2018 at 11:37:51PM +0100, Mateusz Guzik wrote: > On Fri, Jan 12, 2018 at 8:59 PM, Mark Johnston wrote: > > > Modified: head/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c > > ============================================================ > > ================== > > --- head/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c > > Fri Jan 12 18:44:28 2018 (r327887) > > +++ head/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c > > Fri Jan 12 19:59:46 2018 (r327888) > > @@ -3654,6 +3654,24 @@ dtrace_dif_variable(dtrace_mstate_t *mstate, > > dtrace_st > > return (dtrace_dif_varstr( > > (uintptr_t)curthread->t_procp->p_zone->zone_name, > > state, mstate)); > > +#elif defined(__FreeBSD__) > > + /* > > + * On FreeBSD, we introduce compatibility to zonename by falling > > through > > + * into jailname. > > + */ > > + case DIF_VAR_JAILNAME: > > + if (!dtrace_priv_kernel(state)) > > + return (0); > > + > > + return (dtrace_dif_varstr( > > + (uintptr_t)curthread->t_procp- > > >p_ucred->cr_prison->pr_name, > > + state, mstate)); > > + > > > > Why t_procp? It's the field name used in upstream (illumos) code, but we can just use the FreeBSD field names. > curthread->td_proc creds are what is used for permission > checking and it > rarely temporarily goes out of sync with proc's creds. However, if someone > changes creds > while this tracing is enabled this extra dereference risks accessing a > freed object. On the > other hand curthread creads are always safe to read. Thanks. I'll fix this.