From owner-freebsd-ports@FreeBSD.ORG Fri Nov 21 17:12:44 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A4E0131E for ; Fri, 21 Nov 2014 17:12:44 +0000 (UTC) Received: from smtprelay04.ispgateway.de (smtprelay04.ispgateway.de [80.67.31.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3A4C5D88 for ; Fri, 21 Nov 2014 17:12:44 +0000 (UTC) Received: from [78.35.134.216] (helo=fabiankeil.de) by smtprelay04.ispgateway.de with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.84) (envelope-from ) id 1Xrrl6-0008Vi-0W for freebsd-ports@freebsd.org; Fri, 21 Nov 2014 18:12:36 +0100 Date: Fri, 21 Nov 2014 18:01:08 +0100 From: Fabian Keil To: freebsd-ports@freebsd.org Subject: Re: Request for (i386) testing: american fuzzy lop Message-ID: <6f44289d.63c6d622@fabiankeil.de> In-Reply-To: References: <3dc1c153.7b7b9177@fabiankeil.de> <546DF8A5.3060601@gmail.com> <3fb914c3.1002708a@fabiankeil.de> <1557502e.1751489a@fabiankeil.de> Reply-To: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/L_6/tikl2bRELzBDQ_6m8yG"; protocol="application/pgp-signature" X-Df-Sender: Nzc1MDY3 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2014 17:12:44 -0000 --Sig_/L_6/tikl2bRELzBDQ_6m8yG Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Jan Beich wrote: > Fabian Keil writes: >=20 > >> [*] Testing the CC wrapper and instrumentation output... > >> AFL_QUIET=3D1 AFL_INST_RATIO=3D100 AFL_PATH=3D. ./afl-clang -O2 -pipe > >> -fstack-protector -fno-strict-aliasing -Wall -D_FORTIFY_SOURCE=3D2 > >> -Wno-pointer-sign -DAFL_PATH=3D\"/prefix/afl-0.60b/lib/afl\" > >> -DDOC_PATH=3D\"/prefix/afl-0.60b/share/doc/afl\" -DVERSION=3D\"0.60b\" > >> -Wno-format test-instr.c -o test-instr > >> /tmp/.afl-19244-1416499444.s: Assembler messages: > >> /tmp/.afl-19244-1416499444.s:222: Error: unknown pseudo-op: `.cfi_se= ctions' > >> clang: error: assembler command failed with exit code 1 (use -v to > >> see invocation) > > > > I updated the port to (hopefully) use as from ports on i386: > > http://www.fabiankeil.de/sourcecode/freebsd/afl-61b.shar > > > > Does this make a difference? >=20 > Maybe, if you want to force devel/binutils on 9.x users. It'd be nice to > debug why clang misbehaves. Anyway, this version has wrong checksum. >=20 > =3D> afl-0.61b.tgz doesn't seem to exist in /portdistfiles/. > =3D> Attempting to fetch http://lcamtuf.coredump.cx/afl/releases/afl-0.= 61b.tgz > fetch: http://lcamtuf.coredump.cx/afl/releases/afl-0.61b.tgz: size mism= atch: expected 678088, actual 678234 The tarball got re-rolled ... > After fixing I've tested on 11.0C i386, 10.1R i386, 10.0R amd64, 9.3R i38= 6, > 9.1R i386, 8.4R amd64 + tainted host on 11.0C amd64. For one, 8.x exhibit= =20 > another old GNU as(1) issue: >=20 > [*] Testing the CC wrapper and instrumentation output... > AFL_QUIET=3D1 AFL_INST_RATIO=3D100 AFL_PATH=3D. ./afl-gcc -O2 -pipe -fs= tack-protector -fno-strict-aliasing -Wall -D_FORTIFY_SOURCE=3D2 -Wno-pointe= r-sign -DAFL_PATH=3D\"/prefix/afl-0.61b/lib/afl\" -DDOC_PATH=3D\"/prefix/af= l-0.61b/share/doc/afl\" -DVERSION=3D\"0.61b\" -Wno-format test-instr.c -o t= est-instr > /tmp/.afl-16870-1416574405.s: Assembler messages: > /tmp/.afl-16870-1416574405.s:572: Error: suffix or operands invalid for= `lahf' > /tmp/.afl-16870-1416574405.s:593: Error: suffix or operands invalid for= `sahf' > Makefile:65: recipe for target 'test_build' failed >=20 > > +.if ${ARCH} =3D=3D "i386" > > +BUILD_DEPENDS +=3D ${LOCALBASE}/bin/as:${PORTSDIR}/devel/binutils > > +.endif > [...] > > +.if ${ARCH} =3D=3D "i386" > > + ${REINPLACE_CMD} -e 's@\( as_params\[0\] =3D "\)@\1${LOCALBASE}/bin/= @' \ > > + ${WRKSRC}/afl-as.c > > +.endif >=20 > If ${LOCALBASE}/bin/as maybe called after install then you have to > adjust RUN_DEPENDS. Keep in mind package-only users. Indeed. > > > > If not, I'll probably just submit the port marked as broken > > for i386 and try to get this working later on. > A passing by committer may also complain about PORTVERSION vs. DISTVERSIO= N, > lack of LICENSE and DATADIR in pkg-plist. I'm aware of the last two potential complaints and am prepared to deal with them, but I'm not sure I understand the first one. Are you suggesting that using DISTVERSION instead of PORTVERSION would be more appropriate? At least from the comments in bsd.port.mk that's not obvious to me. > diff --git security/afl/Makefile security/afl/Makefile > index e197507..db31853 100644 > --- security/afl/Makefile > +++ security/afl/Makefile Thanks a lot for the patch, I updated the shar file and will submit it tomorrow provided the tarball doesn't get re-rolled again. Fabian --Sig_/L_6/tikl2bRELzBDQ_6m8yG Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlRvb9QACgkQBYqIVf93VJ0+ewCgxrgUx92GXlRSa7sYTQGAUNZ3 OuYAniObuDtUWIjSJUjn9Lf03kj3P0qB =ROI2 -----END PGP SIGNATURE----- --Sig_/L_6/tikl2bRELzBDQ_6m8yG--