From owner-freebsd-current@FreeBSD.ORG Wed Oct 17 21:45:35 2012 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B2A47E3D; Wed, 17 Oct 2012 21:45:35 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id B44918FC14; Wed, 17 Oct 2012 21:45:34 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id AAA10240; Thu, 18 Oct 2012 00:45:29 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1TObQe-0000UF-Tu; Thu, 18 Oct 2012 00:45:28 +0300 Message-ID: <507F26F7.8090302@FreeBSD.org> Date: Thu, 18 Oct 2012 00:45:27 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:16.0) Gecko/20121013 Thunderbird/16.0.1 MIME-Version: 1.0 To: Guido Falsi , Martin Matuska Subject: Re: Regression with ZFS on recent current References: <507EE9C1.7060800@madpilot.net> <507F1D9E.3010803@FreeBSD.org> In-Reply-To: <507F1D9E.3010803@FreeBSD.org> X-Enigmail-Version: 1.4.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "current@FreeBSD.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2012 21:45:35 -0000 on 18/10/2012 00:05 Andriy Gapon said the following: > on 17/10/2012 20:24 Guido Falsi said the following: >> Hi! >> >> While testing portshaker I found a regression in latest current. >> >> portshaker depends on ZFS(when enabling ZFS support) remounting >> filesystems on the fly when changing the mountpoint property. This is >> working as expected on 9.x while on 10-current is not working. Problem >> has appeared sometime before October 3rd. > > Can you clarify what you mean but this date? > That the problem didn't exist in head until recently? Can you name a date when > the problem didn't exists in head then? Oh, hmm, not sure if it is a bug that we imported from upstream or a porting mistake. Before r238391 do_prefix variable in zfs_prop_set (in cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c) was always initialized. Now it is either explicitly set to B_FALSE or left alone uninitialized. http://svnweb.freebsd.org/base/head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c?r1=237119&r2=238391&pathrev=238391 >> Here is some sample output from a9.x machine and a 10-current one: >> >> root@micro:~ [0]# uname -a >> FreeBSD micro.madpilot.net 9.1-PRERELEASE FreeBSD 9.1-PRERELEASE #0 >> r239180: Sat Aug 11 00:14:47 CEST 2012 >> root@micro.madpilot.net:/usr/obj/usr/src/sys/MICRO amd64 >> root@micro:~ [0]# zfs create tank/test >> root@micro:~ [0]# touch /test/baz >> root@micro:~ [0]# zfs set mountpoint=/foo tank/test >> root@micro:~ [0]# ls -ld /foo >> drwxr-xr-x 2 root wheel 3 Oct 17 19:18 /foo >> root@micro:~ [0]# ls -l /foo/ >> total 1 >> -rw-r--r-- 1 root wheel 0 Oct 17 19:18 baz >> root@micro:~ [0]# zfs list tank/test >> NAME USED AVAIL REFER MOUNTPOINT >> tank/test 144K 826G 144K /foo >> >> >> root@marvin:~ [0]# uname -a >> FreeBSD marvin.madpilot.net 10.0-CURRENT FreeBSD 10.0-CURRENT #7 >> r241638: Wed Oct 17 14:33:18 CEST 2012 >> root@marvin.madpilot.net:/usr/obj/usr/src/sys/MARVIN amd64 >> root@marvin:~ [0]# zfs create tank/test >> root@marvin:~ [0]# touch /test/baz >> root@marvin:~ [0]# zfs set mountpoint=/foo tank/test >> root@marvin:~ [0]# ls -ld /foo >> ls: /foo: No such file or directory >> root@marvin:~ [1]# ls -l /foo/ >> ls: /foo/: No such file or directory >> root@marvin:~ [1]# ls -ld /test >> drwxr-xr-x 2 root wheel 3 Oct 17 19:19 /test >> root@marvin:~ [0]# zfs list tank/test >> NAME USED AVAIL REFER MOUNTPOINT >> tank/test 31K 240G 31K /foo >> >> >> Is this known? is the new behavior expected? >> >> Am I doing something stupid? >> >> Thanks in advance >> > > -- Andriy Gapon