From owner-freebsd-current@FreeBSD.ORG Wed Jun 4 18:14:35 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD8961065675 for ; Wed, 4 Jun 2008 18:14:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 373C38FC21 for ; Wed, 4 Jun 2008 18:14:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m54ICTuR087314; Wed, 4 Jun 2008 14:13:13 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "M. Warner Losh" Date: Wed, 4 Jun 2008 11:26:28 -0400 User-Agent: KMail/1.9.7 References: <200805281715.39536.jhb@freebsd.org> <20080604.001253.1683325662.imp@bsdimp.com> <20080604.011215.1723237511.imp@bsdimp.com> In-Reply-To: <20080604.011215.1723237511.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806041126.28347.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Wed, 04 Jun 2008 14:13:13 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7363/Wed Jun 4 12:58:30 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.4 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: current@freebsd.org Subject: Re: cs(4) MPSAFE patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2008 18:14:35 -0000 On Wednesday 04 June 2008 03:12:15 am M. Warner Losh wrote: > In message: <20080604.001253.1683325662.imp@bsdimp.com> > "M. Warner Losh" writes: > : In message: <200805281715.39536.jhb@freebsd.org> > : John Baldwin writes: > : : I have a patch to make cs(4) MPSAFE. As with previous patches, ENOHARDWARE. > : : If you care about this driver, test the patch. > : : > : : http://www.FreeBSD.org/~jhb/patches/cs.patch > : > : This patch appears to work for me, but I've not stress tested the > : interface. > : > : I did have to make a bunch of other changes to the driver to fix some > : obvious bogons that got in my way. These bogons are in the cs driver, > : not in your patches to the cs driver. I'm flushing those into svn and > : looping back the changes plus your patches to make sure things still > : work. I'll report more when I know more. Note: this is PCMCIA card > : only (IBM EtherJet Ethernet PC Card). > : > : I can confirm that your patch still applies after my changes, although > : with a fuzz factor. > > Upon further testing, I've discovered that the driver neglects to tear > down the ISR. > > http://people.freebsd.org/~imp/cs.patch.new > > fixes the problem, but may also have some stray goo in it too. I've updated cs.patch, I just put the teardown in detach as that is the only place it is needed (other drivers are similar). Also, I broke the watchdog timer in the patch you have, so you may want to fetch the updated patch for that. Thanks for testing this. -- John Baldwin