From owner-freebsd-multimedia@FreeBSD.ORG Thu Sep 6 14:11:38 2007 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5445916A468 for ; Thu, 6 Sep 2007 14:11:38 +0000 (UTC) (envelope-from c0rn@o2.pl) Received: from tur.go2.pl (tur.go2.pl [193.17.41.50]) by mx1.freebsd.org (Postfix) with ESMTP id 833D213C4CE for ; Thu, 6 Sep 2007 14:11:37 +0000 (UTC) (envelope-from c0rn@o2.pl) Received: from poczta.o2.pl (mx12.go2.pl [193.17.41.142]) by tur.go2.pl (o2.pl Mailer 2.0.1) with ESMTP id 8B3B32313D3 for ; Thu, 6 Sep 2007 15:45:11 +0200 (CEST) Received: from poczta.o2.pl (mx12 [127.0.0.1]) by poczta.o2.pl (Postfix) with ESMTP id 251553E809B; Thu, 6 Sep 2007 15:45:09 +0200 (CEST) Received: from caprica.slowicza.org (bak124.neoplus.adsl.tpnet.pl [83.27.174.124]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by poczta.o2.pl (Postfix) with ESMTP; Thu, 6 Sep 2007 15:45:09 +0200 (CEST) Date: Thu, 6 Sep 2007 15:44:46 +0200 From: =?ISO-8859-2?Q?Pawe=B3_P=EAkala?= To: Danny Pansters Message-ID: <20070906154446.1ca99a02@caprica.slowicza.org> In-Reply-To: <200709060114.15244.danny@ricin.com> References: <1188929661.62988@caprica.slowicza.org> <200709042112.07555.fbsd.multimedia@rachie.is-a-geek.net> <200709060114.15244.danny@ricin.com> X-Mailer: Claws Mail 2.10.0 (GTK+ 2.10.14; i386-portbld-freebsd6.2) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Cc: freebsd-multimedia@freebsd.org Subject: Re: [patch] multimedia/kmplayer update to 0.9.4a X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2007 14:11:38 -0000 Hello, Dnia Thu, 6 Sep 2007 01:14:14 +0200 Danny Pansters napisa=B3(a): > >If you use OPTIONS, you shouldn't use constructs like exists() at all, >but rather only have the proper LIB_DEPENDS (or USE_*) added if the >option is set to on. Even if, for example, xinelib is present, if the >user keeps the option unset it should *not* build or install >kxineplayer. Or remove the OPTIONS if it's not possible to use them as >intended. If you have OPTIONS they should override anything else >(POLA). Hmm funny, my patch _does_ this you describe above I don`t see why you think it`s wrong.=20 > >Attached is a reworked diff for the port update plus proper OPTIONS >handling and removing non essential comments. Special flags for gcc42 >don't seem to be needed (anymore?). Besides, disabling the standard >-O2 flag should only be done as the very last resort IMHO because if >that goes wrong there must be some underlying problem. I don't see >-pedantic when building with either g++34 or g++42. If needed, I don't >mind removing that. > Your patch removes some cruft that mine didn`t address, probably I should considered this too, my bad. BTW according to project homepage latest stable version is 0.9.4a and your patch is on version 0.9.4. regards, Pawe=B3