Date: Tue, 26 Apr 2011 09:35:17 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" <bz@freebsd.org>, Robert Watson <rwatson@freebsd.org>, svn-src-head@freebsd.org, Warner Losh <imp@bsdimp.com> Subject: Re: svn commit: r220982 - in head: . sys/amd64/conf sys/arm/conf sys/conf sys/i386/conf sys/ia64/conf sys/mips/conf sys/mips/malta sys/pc98/conf sys/powerpc/conf sys/sparc64/conf sys/sun4v/conf Message-ID: <20110426073517.GF2472@garage.freebsd.pl> In-Reply-To: <4DB6721B.3020600@FreeBSD.org> References: <alpine.BSF.2.00.1104241140070.36270@fledge.watson.org> <4DB441B0.8020906@FreeBSD.org> <CD028561-B550-4896-BE65-7C827BE6A34A@FreeBSD.org> <20110425134531.GA4391@garage.freebsd.pl> <50385B7B-7EC8-4BC3-8F88-83F9EB4096FB@bsdimp.com> <4DB5A166.9010302@FreeBSD.org> <67F62848-FAA3-4C46-A95A-DA7C82281898@bsdimp.com> <4DB5B0A9.4030805@FreeBSD.org> <20110426070020.GC2472@garage.freebsd.pl> <4DB6721B.3020600@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--65ImJOski3p8EhYV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Apr 26, 2011 at 10:19:55AM +0300, Alexander Motin wrote:
> On 26.04.2011 10:00, Pawel Jakub Dawidek wrote:
> >On Mon, Apr 25, 2011 at 08:34:33PM +0300, Alexander Motin wrote:
> >>I've thought about the process of fixing hardcoded provider names there,
> >>and it is absolutely not trivial. If we take the "symlinking" way (patch
> >>is already posted to current@), I think it will be much easier for
> >>everybody, and especially users, if I hack all mentioned above GEOM
> >>classes to ignore adX/adaY difference in provider names. And it should
> >>perfectly fit into remaining time window.
> >
> >Could you be more specific what the hack would do exactly?
>=20
> I would write some comparison function, which would search both
> names for adX/adaY prefixes, if they found on both arguments,
> trimmed them and compared remaining parts.
>=20
> I think for usual purpose of name hardcoding device name part is
> less important. Comparing partition names part should be enough. The
> tricky part there is to properly identify device part, so I was
> thinking about specific hack for adX/adaY.
I was wondering how would you match X and Y, but this is indeed not
important. So on taste we could do (totally untested):
static bool
provider_name_matches(const char *ppname, const char *hcname)
{
if (strcmp(ppname, hcname) =3D=3D 0)
return (true);
if (strncmp(hcname, "ad", 2) !=3D 0 ||
hcname[2] < '0' || hcname[2] > '9') {
return (false);
}
if (strncmp(ppname, "ada", 3) !=3D 0 ||
ppname[3] < '0' || ppname[3] > '9') {
return (false);
}
/* Skip 'ad[0-9]+'. */
hcname +=3D 3;
while (hcname[0] >=3D '0' && hcname[0] <=3D '9')
hcname++;
/* Skip 'ada[0-9]+'.
ppname +=3D 4;
while (ppname[0] >=3D '0' && ppname[0] <=3D '9')
ppname++;
return (strcmp(ppname, hcname) =3D=3D 0);
}
That could work.
Another possibility I was thinking of was to create GEOM providers for
both names and orphan the other name once one of them is opened for
writing.
--=20
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://yomoli.com
--65ImJOski3p8EhYV
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)
iEYEARECAAYFAk22dbUACgkQForvXbEpPzQbigCeNwDcYVHDWMG/NqzX+qOsTWXz
78cAnjuTBx9e7BEOTy/1NohoWyeiBGs1
=jhHX
-----END PGP SIGNATURE-----
--65ImJOski3p8EhYV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110426073517.GF2472>