From owner-svn-src-all@freebsd.org Mon Jun 22 19:03:40 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 67B2733870D; Mon, 22 Jun 2020 19:03:40 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49rJj80cSgz4Cvw; Mon, 22 Jun 2020 19:03:39 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 05MJ3cfM011717; Mon, 22 Jun 2020 12:03:38 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 05MJ3cRJ011716; Mon, 22 Jun 2020 12:03:38 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202006221903.05MJ3cRJ011716@gndrsh.dnsmgr.net> Subject: Re: svn commit: r362338 - in head: share/man/man4 sys/conf sys/kern sys/netinet sys/netinet6 sys/netipsec sys/netpfil/pf In-Reply-To: To: John Baldwin Date: Mon, 22 Jun 2020 12:03:38 -0700 (PDT) CC: Mark Johnston , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 49rJj80cSgz4Cvw X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2020 19:03:40 -0000 > On 6/21/20 6:10 PM, Mark Johnston wrote: > > On Fri, Jun 19, 2020 at 08:33:35AM -0700, John Baldwin wrote: > >> On 6/18/20 12:32 PM, Mark Johnston wrote: > >>> Author: markj > >>> Date: Thu Jun 18 19:32:34 2020 > >>> New Revision: 362338 > >>> URL: https://svnweb.freebsd.org/changeset/base/362338 > >>> > >>> Log: > >>> Add the SCTP_SUPPORT kernel option. > >>> > >>> This is in preparation for enabling a loadable SCTP stack. Analogous to > >>> IPSEC/IPSEC_SUPPORT, the SCTP_SUPPORT kernel option must be configured > >>> in order to support a loadable SCTP implementation. > >>> > >>> Discussed with: tuexen > >>> MFC after: 2 weeks > >>> Sponsored by: The FreeBSD Foundation > >> > >> Do you want to add similar handling to sys/conf/config.mk that we have > >> for IPsec? Also, do we want to avoid building sctp.ko if it is in the > >> kernel like we do for ipsec.ko and/or only build it if the kernel contains > >> SCTP_SUPPORT? (For ipsec.ko we had to do that as it wouldn't compile, not > >> sure if the same is true for sctp.ko) > > > > Sorry for the delay. > > I think we do indeed want similar handling in config.mk, I will work on > > it. It is probably also reasonable to avoid compiling sctp.ko when > > SCTP_SUPPORT is not defined, though I can't see a reason that wouldn't > > work today since SCTP_SUPPORT is not used in any headers. > > Ok. ipsec.ko mattered more when the build broke. Whether or not we compile > "duplicate" modules for kernels is perhaps a larger question. I think I > might favor that change, but it is a larger change that merits some thought. > In particular, you want good code coverage for things like LINT builds, so > maybe we really should still compile modules whenever possible. As a person that builds a lot of stuff into his kernel, aka I run moduleless most of the time, I still would like the modules to build so I know I have not busted that with other changes. It is just too easy to do, IMHO. > -- > John Baldwin -- Rod Grimes rgrimes@freebsd.org