From owner-freebsd-bugs Thu May 25 23:13:57 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from asky.kyoto-inet.or.jp (asky.picky.or.jp [202.245.159.17]) by hub.freebsd.org (Postfix) with ESMTP id B4B2337B542 for ; Thu, 25 May 2000 23:13:53 -0700 (PDT) (envelope-from yab@astem.or.jp) Received: from astemgw.astem.or.jp (astemgw.astem.or.jp [133.18.80.1]) by asky.kyoto-inet.or.jp (8.9.3/3.7W-19990128) with ESMTP id PAA20137; Fri, 26 May 2000 15:13:43 +0900 Received: from astemfs.astem.or.jp (astemfs.astem.or.jp [133.18.80.2]) by astemgw.astem.or.jp (8.9.3/3.7W-19991121) with ESMTP id PAA00598; Fri, 26 May 2000 15:13:43 +0900 (JST) Received: from astem.or.jp (astemfs.astem.or.jp [133.18.80.2]) by astemfs.astem.or.jp (8.9.3/3.7W-20000503) with ESMTP id PAA29126; Fri, 26 May 2000 15:13:43 +0900 (JST) Message-Id: <200005260613.PAA29126@astemfs.astem.or.jp> To: Gregory Bond Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: kern/18526: mx does not receive ethernet broadcast packet In-reply-to: Your message of "Fri, 26 May 2000 15:52:35 +1000." <200005260552.PAA20510@lightning.itga.com.au> Mime-Version: 1.0 (generated by tm-edit 7.92) Content-Type: text/plain; charset=US-ASCII Date: Fri, 26 May 2000 15:13:42 +0900 From: Kenji Yabuuchi Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >>>>> On Fri, 26 May 2000 15:52:35 +1000, Gregory Bond said: >> + if (t->mx_did == MX_DEVICEID_987x5) >> + if (rev != MX_REVISION_98715AEC) >> + t++; >> + else if (rev >= MX_REVISION_98725) >> + t++; |> Either I'm dense or this is not right (or at the very least, wildly redundant). |> if (rev != a) t++; |> else if (rev >= b) t++; |> makes no sense when a & b are constant. Yes, you're right. This part should be: if (rev != MX_REVISION_98715AEC || rev >= MX_REVISION_98725) t++; -- ASTEM RI yab@astem.or.jp To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message