From owner-svn-src-head@FreeBSD.ORG  Wed Oct 26 08:46:50 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 29AE7106564A;
	Wed, 26 Oct 2011 08:46:50 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from mx0.hoeg.nl (mx0.hoeg.nl [IPv6:2a01:4f8:101:5343::aa])
	by mx1.freebsd.org (Postfix) with ESMTP id BA3398FC0C;
	Wed, 26 Oct 2011 08:46:49 +0000 (UTC)
Received: by mx0.hoeg.nl (Postfix, from userid 1000)
	id CED942A28CBC; Wed, 26 Oct 2011 10:46:48 +0200 (CEST)
Date: Wed, 26 Oct 2011 10:46:48 +0200
From: Ed Schouten <ed@80386.nl>
To: Garrett Cooper <yanegomi@gmail.com>
Message-ID: <20111026084648.GF63910@hoeg.nl>
References: <201110260749.p9Q7nlj3038764@svn.freebsd.org>
	<4E5789B4-3370-4EE0-A5BE-A753070E0FD6@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="65ImJOski3p8EhYV"
Content-Disposition: inline
In-Reply-To: <4E5789B4-3370-4EE0-A5BE-A753070E0FD6@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r226785 - head
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2011 08:46:50 -0000


--65ImJOski3p8EhYV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Garrett,

* Garrett Cooper <yanegomi@gmail.com>, 20111026 09:54:
> I addressed the overall issue a bit more thoroughly via bin/143830 .
> Could you take a look at that PR and let me know what you think of it?

The patch looks okay, but I think it can be simplified. Maybe we should
get rid of all the `RESCUE' bits from the atmconfig source code itself
and add something like this to the Makefile:

=2Eif !defined(RESCUE) && ${MK_BNSMP} !=3D "no"
CFLAGS+=3D -DWITH_BSNMP
=2Eendif

That way you can simply use `#ifdef WITH_BSNMP' throughout the source
files.

Thanks,
--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--65ImJOski3p8EhYV
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)

iQIcBAEBAgAGBQJOp8j4AAoJEG5e2P40kaK7OAYP/RivBi2KG07kmVRsQ+gK5mAv
hjl/gkrwyXp1TGsRfdgRix5p4OyWxJIAIda8YJt41MxdVEDXtuG75iLgAJCT+H/r
Dh5q1dscb8ma4WlXabPsH5RgEn4dwZvLoxRROqzLObBfFYCOPKugO+z0DrIgZ4OQ
cCkCcp0nPt4GQ6rRu/Lki8EWZJGPEfxiZ8UmI6U7rOWu4GDKKkyHXDUtKJrWaBqO
allav3z9/sDHrLGucC52sBVSLRxEuYTxdfDeri25dPcjDXjexdzZnvos8ubqYI+L
VzNvF7Vbw8iZt104RuhmLjeOWlXq4rkEq+sN4ANju3JVEsligEm0zQ89hqSQjZP6
tGmllf1xfqDpuzgm3uvyGo4Zdy/N/rt8FdhE3ykmrrRkWcgriMzwX0TFzm0Nro+A
dOZBzUlWEPSN6vfdS1y+GlOFH+qwRb9LsrzQMRBHGVsSQ4Fl3gpHjgztcmq5JS0u
hrpz9VfjrZZDaHDewJ7ErICjC65ChFTplr3itH4GN6pAnpz8J04mtaAL0PlNlCbo
YiVWbNcthJSzOG8Fam+DNyPCEAY9QqIzc4IWXdU2iVaxOzZ2fdZqpOD8AwBGbQIZ
GLxqY5/BmI1C//gsH9WWNgKf8H/eoneNI7bBGp1F3FTC1/N6/O6Nn4n8jT8rwrCp
It1sZhUi+46riNc05t4s
=2kid
-----END PGP SIGNATURE-----

--65ImJOski3p8EhYV--