Date: Thu, 21 Feb 2002 12:01:49 -0700 From: "Justin T. Gibbs" <gibbs@scsiguy.com> To: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> Cc: freebsd-scsi@FreeBSD.ORG, joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) Subject: Re: READ_6 patch (Re: RBC support patch) Message-ID: <200202211901.g1LJ1nI48461@aslan.scsiguy.com> In-Reply-To: Your message of "Thu, 21 Feb 2002 23:58:41 %2B0900." <ybsg03ux4ny.wl@ett.sat.t.u-tokyo.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
>> This seems right way to go. > >How about this? >Could you review this patch? Close. Perform the test inside daerror(). Daerror is supposed to filter out any errors specific to the da driver prior to calling the generic error routine, so this is the place to handle this. You should also only need to do the filtering if the ccb has an error flagged in its ccb header. This should avoid any unecessary work on transactions that haven't failed. Lastly, you need to actually requeue the transaction (xpt_action() followed by a release of the device queue if the transaction was marked as having frozen the queue). Thanks for looking into this! -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202211901.g1LJ1nI48461>