From owner-freebsd-audit  Thu Jun 14 15:11:43 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138])
	by hub.freebsd.org (Postfix) with ESMTP id A9F6137B405
	for <audit@FreeBSD.org>; Thu, 14 Jun 2001 15:11:40 -0700 (PDT)
	(envelope-from dima@unixfreak.org)
Received: from hornet.unixfreak.org (hornet [63.198.170.140])
	by bazooka.unixfreak.org (Postfix) with ESMTP
	id A33673E28; Thu, 14 Jun 2001 15:11:29 -0700 (PDT)
To: Peter Pentchev <roam@orbitel.bg>
Cc: audit@FreeBSD.org
Subject: Re: fstat(1) patches to recognize FIFO's 
In-Reply-To: <20010614134953.E837@ringworld.oblivion.bg>; from roam@orbitel.bg on "Thu, 14 Jun 2001 13:49:53 +0300"
Date: Thu, 14 Jun 2001 15:11:29 -0700
From: Dima Dorfman <dima@unixfreak.org>
Message-Id: <20010614221129.A33673E28@bazooka.unixfreak.org>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

Peter Pentchev <roam@orbitel.bg> writes:
> Index: src/usr.bin/fstat/fstat.c
> ===================================================================
> RCS file: /home/ncvs/src/usr.bin/fstat/fstat.c,v
> retrieving revision 1.31
> diff -u -r1.31 fstat.c
> --- src/usr.bin/fstat/fstat.c	2001/05/29 20:39:47	1.31
> +++ src/usr.bin/fstat/fstat.c	2001/06/14 10:48:52
> @@ -366,6 +366,13 @@
>  					file.f_flag);
>  		}
>  #endif
> +#ifdef DTYPE_FIFO
> +		else if (file.f_type == DTYPE_FIFO) {
> +			if (checkfile == 0)
> +				vtrans((struct vnode *)file.f_data, i,
> +					file.f_flag);

Style bug.  A second-level indent should be 4 spaces.  Actually, this
file is screwed up in this respect; at a quick glance, it looks like
some of it uses 4 spaces, while some other parts indent to the opening
parenthesis like you did above.  Since it's already inconsistent, I
think it's best to follow the current guideline, which is to indent 4
spaces.

Other than that, looks great!

					Dima Dorfman
					dima@unixfreak.org


> +		}
> +#endif
>  		else {
>  			dprintf(stderr,
>  				"unknown file type %d for file %d of pid %d\n",
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-audit" in the body of the message
> 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message