From owner-freebsd-net@FreeBSD.ORG  Wed Dec 14 08:39:04 2005
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A631716A431;
	Wed, 14 Dec 2005 08:39:04 +0000 (GMT)
	(envelope-from sten@blinkenlights.nl)
Received: from ford.blinkenlights.nl (ford.blinkenlights.nl [213.204.211.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 88EEE43D81;
	Wed, 14 Dec 2005 08:38:45 +0000 (GMT)
	(envelope-from sten@blinkenlights.nl)
Received: from tea.blinkenlights.nl (tea.blinkenlights.nl [192.168.1.21])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by ford.blinkenlights.nl (Postfix) with ESMTP id 92222BDFA;
	Wed, 14 Dec 2005 09:38:46 +0100 (CET)
Received: by tea.blinkenlights.nl (Postfix, from userid 101)
	id 82FCE286; Wed, 14 Dec 2005 09:40:54 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by tea.blinkenlights.nl (Postfix) with ESMTP
	id 76BFD1C4; Wed, 14 Dec 2005 09:40:54 +0100 (CET)
Date: Wed, 14 Dec 2005 09:40:54 +0100 (CET)
From: Sten Spans <sten@blinkenlights.nl>
To: Andrew Thompson <thompsa@freebsd.org>
In-Reply-To: <20051214022353.GB5248@heff.fud.org.nz>
Message-ID: <Pine.SOC.4.61.0512140938410.5102@tea.blinkenlights.nl>
References: <20051214022353.GB5248@heff.fud.org.nz>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-net@freebsd.org
Subject: Re: m_copypacket in if_bridge
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Dec 2005 08:39:04 -0000

On Wed, 14 Dec 2005, Andrew Thompson wrote:

> Hi,
>
>
> I have realised that if_bridge uses m_copypacket() in an unsafe way.
> The copied multicast packet is sent back into ether_input for local
> processing so that ipv6 works but m_copypacket() returns a readonly
> mbuf. The layer3 header needs to be aligned so I have changed this to
> m_dup+m_copyup.
>
> Can I get a review to ensure this is the correct fix

This certainly looks like a reasonable fix.
Thanks for making life better for sparc and alpha :)

-- 
Sten Spans

"There is a crack in everything, that's how the light gets in."
Leonard Cohen - Anthem