From owner-cvs-src@FreeBSD.ORG Thu May 25 14:10:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9581C16A4DC; Thu, 25 May 2006 14:10:40 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 278B043D5F; Thu, 25 May 2006 14:10:34 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [IPv6:::1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k4PE8PtP032026; Thu, 25 May 2006 08:08:26 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 25 May 2006 08:08:25 -0600 (MDT) Message-Id: <20060525.080825.1649780628.imp@bsdimp.com> To: glebius@FreeBSD.ORG From: "M. Warner Losh" In-Reply-To: <20060525111035.GI27819@FreeBSD.org> References: <200605241726.k4OHQG59037586@repoman.freebsd.org> <20060525111035.GI27819@FreeBSD.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/pccbb pccbb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2006 14:10:42 -0000 In message: <20060525111035.GI27819@FreeBSD.org> Gleb Smirnoff writes: : On Wed, May 24, 2006 at 05:26:16PM +0000, Warner Losh wrote: : W> imp 2006-05-24 17:26:16 UTC : W> : W> FreeBSD src repository : W> : W> Modified files: : W> sys/dev/pccbb pccbb.c : W> Log: : W> Suspend the children before we turn off card events in hardware. This : W> was done, I believe, to work around some cards having issues in the : W> suspend case. I think that this helped my Sony VAIO TS505 work better : W> when it had certain wireless cards in it and I did a apm -z. I've not : ^^^^^^^ : W> tested suspend/resume on other laptops in a long time, so I hope this : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ : W> doesn't cause greif. Please let me know if it does. : ^^^^^^^^^^^^^^^^^^^ : : Is this a joke, that I can't understand? :( : : This file has broken APM suspend since revision 1.122, which was made : almost a year ago. I've told that several times, and I still hope that : this will be fixed before RELENG_7. The problem is not in suspending : children, since suspend is broken w/o any cards in slot. The problem is : in DELAY -> tsleep() conversion. The latter is not working, when : system is suspending. The problem is elsewhere in the system if it is the use of tsleep. Get me a laptop that has otherwise working suspend/resume and I'll fix this. Warner