From owner-svn-src-head@freebsd.org Mon Nov 5 23:00:43 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 095D8110E8D7; Mon, 5 Nov 2018 23:00:43 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 894D179294; Mon, 5 Nov 2018 23:00:42 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 4B5AA8D2B; Mon, 5 Nov 2018 23:00:42 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 8D3267196; Mon, 5 Nov 2018 23:00:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id slcF7EmWJo8y; Mon, 5 Nov 2018 23:00:38 +0000 (UTC) Subject: Re: svn commit: r339636 - in head: . share/mk DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 6A8057189 To: Alex Richardson , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201810230631.w9N6VPR4008554@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8CGwwF AlrozigFCQpgez0ACgkQNddxu25Gl8+m5Af/R3VEdxNMAcDIes9ADhQyofj20SPV3eCJ3HYR OebTSuNdOudGt4AAyA8Ks94u9hiIp5IGsc6RDsT9W7O2vgXhd6eV3eiY5Oif5xLIYrIDVu1Y 1GyRxRrPEn/QOqDN6uFZCPwK1aOapGcYCrO9lB0gMuTVfgHanU61rgC9tMX0OoAOyRd+V3/M 8lDNhjJdF/IpO3SdYzKfkwduy4qamw4Gphcx/RfYQvYLq/eDkP8d50PphWdboqWBwNRHayro W/07OGzfxM5fJ5mBsXPQcO2QcRjkyHf6xCM6Hi1qQL4OnXMNE/ZTX0lnOj1/pH93TlzSHZMP TaiiA/MBD3vGsXBmBg== Organization: FreeBSD Message-ID: <9612d267-91dc-b1ee-7530-284376f08f08@FreeBSD.org> Date: Mon, 5 Nov 2018 15:00:37 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201810230631.w9N6VPR4008554@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hBqK5Vdxe07UnxEP7yEVJYemQEKdP1PPy" X-Rspamd-Queue-Id: 894D179294 X-Spamd-Result: default: False [-108.50 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; ALLOW_DOMAIN_WHITELIST(-100.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; HAS_ATTACHMENT(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; DMARC_NA(0.00)[FreeBSD.org]; R_SPF_SOFTFAIL(0.00)[~all]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; IP_SCORE(-3.29)[ip: (-8.63), ipnet: 96.47.64.0/20(-4.31), asn: 11403(-3.45), country: US(-0.06)]; MX_GOOD(-0.01)[cached: mx1.FreeBSD.org]; NEURAL_HAM_SHORT(-1.00)[-1.000,0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 23:00:43 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hBqK5Vdxe07UnxEP7yEVJYemQEKdP1PPy Content-Type: multipart/mixed; boundary="eiYBUoqmRiQcvYiHd4IkzCmmkYhJJEZuZ"; protected-headers="v1" From: Bryan Drewery To: Alex Richardson , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <9612d267-91dc-b1ee-7530-284376f08f08@FreeBSD.org> Subject: Re: svn commit: r339636 - in head: . share/mk References: <201810230631.w9N6VPR4008554@repo.freebsd.org> In-Reply-To: <201810230631.w9N6VPR4008554@repo.freebsd.org> --eiYBUoqmRiQcvYiHd4IkzCmmkYhJJEZuZ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/22/2018 11:31 PM, Alex Richardson wrote: > Author: arichardson > Date: Tue Oct 23 06:31:25 2018 > New Revision: 339636 > URL: https://svnweb.freebsd.org/changeset/base/339636 >=20 > Log: > Only compute the X_COMPILER_*/X_LINKER_* variables when needed > =20 > When building CheriBSD we have to set XLD/XCC/XCFLAGS on the command = line. > This triggers the $XCC !=3D $CC case in bsd.compiler.mk (and the same= for LD > in bsd.linker.mk) which causes it to call ${XCC} --version and > ${XLD} --version (plus various awk+sed+echo calls) in every subdirect= ory. > For incremental builds and stages that only walk the source tree this= is > often the majority of the time spent in that directory. > =20 =2E.. > By only computing the value of the X_COMPILER_*/X_LINKER_* variables = if > _WANT_TOOLCHAIN_CROSS_VARS is set we can reduce the number of cc/ld c= alls > to once per build stage instead of once per recursive make. This sounds wrong. bsd.compiler.mk *already* handles that kind of thing by exporting its computations. Adding a second hack for a similar problem isn't the right solution. > =20 > With this change (and no changes to the sources) the `make includes` = stage > now takes 28 seconds at -j1 instead of 86 seconds. > =20 > Approved By: brooks (mentor) > Differential Revision: https://reviews.freebsd.org/D17046 --=20 Regards, Bryan Drewery --eiYBUoqmRiQcvYiHd4IkzCmmkYhJJEZuZ-- --hBqK5Vdxe07UnxEP7yEVJYemQEKdP1PPy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE+Rc8ssOq6npcih8JNddxu25Gl88FAlvgy5ZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY5 MTczQ0IyQzNBQUVBN0E1QzhBMUYwOTM1RDc3MUJCNkU0Njk3Q0YACgkQNddxu25G l89MOQf/S6gcHKeuiQl6tEJq1vLpA4oN+8HKOTWYXsQs26hCzQ0DVfHo4jbHS9R6 WWUDjULTrKLbZIvs4Y5ql3s6jRX/Okz14nvPPJPeMOL2s8MrrMmuTOuz4OQMLwAw TT+P7fWRC9VjHi47SO12DSgg7lm7XAcdlVar0fGJUwvhKQ8CImqjedMIZNItm+O6 6GnTLM/UvPtR4C6XKutn+MTVrgUh/sXJYUJ2g0RjSOp//FhGFH7f8Q1yIRj3DhxQ FVMze6SN7cNKJ2a6ncZZG3Fsb8HSQVOIQqmg9JwQSNvztrWXzcaFr66JX+/bvYKk rRGVCjoOnKKvmigimQsL0dJHnSKGlg== =dyED -----END PGP SIGNATURE----- --hBqK5Vdxe07UnxEP7yEVJYemQEKdP1PPy--