From owner-freebsd-arm@FreeBSD.ORG  Sat Feb 13 18:10:23 2010
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: arm@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5083C10656C3
	for <arm@FreeBSD.org>; Sat, 13 Feb 2010 18:10:23 +0000 (UTC)
	(envelope-from uqs@FreeBSD.org)
Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2001:470:9a47::1])
	by mx1.freebsd.org (Postfix) with ESMTP id E4F4E8FC29
	for <arm@FreeBSD.org>; Sat, 13 Feb 2010 18:10:22 +0000 (UTC)
Received: from acme.spoerlein.net (localhost.spoerlein.net [IPv6:::1])
	by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id o1DIALId014350
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <arm@FreeBSD.org>; Sat, 13 Feb 2010 19:10:21 +0100 (CET)
	(envelope-from uqs@FreeBSD.org)
Received: (from uqs@localhost)
	by acme.spoerlein.net (8.14.4/8.14.4/Submit) id o1DIALjU014349
	for arm@freebsd.org; Sat, 13 Feb 2010 19:10:21 +0100 (CET)
	(envelope-from uqs@FreeBSD.org)
Date: Sat, 13 Feb 2010 19:10:21 +0100
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@FreeBSD.org>
To: arm@FreeBSD.org
Message-ID: <20100213181021.GR9748@acme.spoerlein.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="envbJBWh7q8WU6mo"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: 
Subject: RFC: patch to crt1.c, fixing a typo/oversight
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Feb 2010 18:10:23 -0000


--envbJBWh7q8WU6mo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Dear ARM devs,

I have no resources to test the following patch, which fixes a typo
regarding the function declaration of _start. If some knowledgable folks
could please review/test the change. Thanks

https://www.spoerlein.net/gitweb/?p=freebsd-head.work/.git;a=commitdiff;h=0e393a134bf00729756f00f539536956fc170dd9

Regards,
Uli

Please keep me cc'ed.

--envbJBWh7q8WU6mo
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: inline; filename="libcsu.diff"
Content-Transfer-Encoding: 8bit

commit 0e393a134bf00729756f00f539536956fc170dd9
Author: Ulrich Spörlein <uqs@spoerlein.net>
Date:   Sat Feb 13 13:41:29 2010 +0100

    Fix prototype for crt1 on arm
    
    XXX: This needs to be checked by arm people

diff --git a/lib/csu/arm/crt1.c b/lib/csu/arm/crt1.c
index 02af3c2..e9ed9e5 100644
--- a/lib/csu/arm/crt1.c
+++ b/lib/csu/arm/crt1.c
@@ -60,8 +60,8 @@ extern int _DYNAMIC;
 extern void _fini(void);
 extern void _init(void);
 extern int main(int, char **, char **);
-extern void _start(int, char **, char **, const struct Struct_Obj_Entry *,
-    void (*)(void), struct ps_strings *);
+extern void __start(int, char **, char **, struct ps_strings *,
+    const struct Struct_Obj_Entry *, void (*)(void));
 
 #ifdef GCRT
 extern void _mcleanup(void);

--envbJBWh7q8WU6mo--