From owner-freebsd-ports@FreeBSD.ORG Wed Mar 31 09:20:07 2010 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 80C891065670 for ; Wed, 31 Mar 2010 09:20:07 +0000 (UTC) (envelope-from gary.jennejohn@freenet.de) Received: from mout6.freenet.de (mout6.freenet.de [IPv6:2001:748:100:40::2:8]) by mx1.freebsd.org (Postfix) with ESMTP id 186B98FC1C for ; Wed, 31 Mar 2010 09:20:07 +0000 (UTC) Received: from [195.4.92.14] (helo=4.mx.freenet.de) by mout6.freenet.de with esmtpa (ID gary.jennejohn@freenet.de) (port 25) (Exim 4.72 #3) id 1Nwu5k-0001uZ-GG; Wed, 31 Mar 2010 11:20:04 +0200 Received: from p57ae2318.dip0.t-ipconnect.de ([87.174.35.24]:31824 helo=ernst.jennejohn.org) by 4.mx.freenet.de with esmtpa (ID gary.jennejohn@freenet.de) (port 25) (Exim 4.72 #3) id 1Nwu5j-0006U3-V1; Wed, 31 Mar 2010 11:20:04 +0200 Date: Wed, 31 Mar 2010 11:20:01 +0200 From: Gary Jennejohn To: d@delphij.net Message-ID: <20100331112001.0951e682@ernst.jennejohn.org> In-Reply-To: <4BB251D1.80505@delphij.net> References: <4BB23953.7000606@FreeBSD.org> <4BB24F6F.2080908@FreeBSD.org> <4BB251D1.80505@delphij.net> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.7; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-ports@FreeBSD.org Subject: Re: x11-toolkits/qt4-gui fails with png and/or zlib.h off64_t X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: gary.jennejohn@freenet.de List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 09:20:07 -0000 On Tue, 30 Mar 2010 12:32:33 -0700 Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 2010/03/30 12:22, Doug Barton wrote: > > Testing it again I see that I didn't go far enough up to find the real > > error, sorry Dirk. > > > > The actual problem seems to be with zlib.h. This is from qt4-gui: > [...] > > -DQ_INTERNAL_QAPP_SRC -DQT_CORE_LIB -D_LARGEFILE64_SOURCE > > -D_LARGEFILE_SOURCE -I/usr/local/share/qt4/mkspecs/freebsd-g++ -I. > > There are some discussion about these _LARGEFILE64_SOURCE usage on zlib > developers' mailing list. > > To put it short, it's now believed that the usage of _LARGEFILE64_SOURCE > on FreeBSD is wrong. I'm not quite sure though, if I should use some > workaround over this, like Mac OS X did (newer zlib has a similar change > by requiring _LFS64_SOURCE): > > Index: zconf.h > =================================================================== > - --- zconf.h (revision 205883) > +++ zconf.h (working copy) > @@ -375,7 +375,7 @@ > # endif > #endif > > - -#ifdef _LARGEFILE64_SOURCE > +#if defined(_LARGEFILE64_SOURCE) && !defined(__FreeBSD__) > # include > #endif > > Index: zlib.h > =================================================================== > - --- zlib.h (revision 205883) > +++ zlib.h (working copy) > @@ -1556,7 +1556,7 @@ > inflateBackInit_((strm), (windowBits), (window), \ > ZLIB_VERSION, sizeof(z_stream)) > > - -#ifdef _LARGEFILE64_SOURCE > +#if defined(_LARGEFILE64_SOURCE) && !defined(__FreeBSD__) > ZEXTERN gzFile ZEXPORT gzopen64 OF((const char *, const char *)); > ZEXTERN off64_t ZEXPORT gzseek64 OF((gzFile, off64_t, int)); > ZEXTERN off64_t ZEXPORT gztell64 OF((gzFile)); > This patch also fixes the build for vlc. -- Gary Jennejohn